Ref #54: Drop ctap-types fork & move to cosey crate (fork) #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfioEmanueleFresta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes progress on upstreaming dependency changes, so we can publish our crate.
Previous upstreaming request was declined, as COSE types were moved out of
ctap-types, and into the standalonecoseycrate (trussed-dev/ctap-types#15).This PR adopts
coseyfor COSE types, and drops ourctap-typesfork in favour of the published crate.See #54.
Changes
ctap-typefork in favour of:trussed-dev/coseyforctap-type::cose(this is no longer part of ctap-types). This fork includes theDeserializetrait forPublicKey, needed in our library.trussed-dev/ctap-typesfor existing non-COSE uses (eg.CredentialProtectionPolicy)ctap-typesto the latest versionserde-indexedto 0.1.1 as required by updatedctap-types(Cargo.toml)#[serde(default)]annotation, as this is currently not supported and fails altogether withserde-indexed 0.1.1: Support forserde(default)trussed-dev/serde-indexed#10Follow-up
Drop the fork once change is upstreamed: trussed-dev/cosey#12