Fix #137: Add RP ID validation with IDNA normalization #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfioEmanueleFresta
force-pushed
the
json-4
branch
from
aec13ac to
c8d2a39
Compare
AlfioEmanueleFresta
force-pushed
the
json-4
branch
from
c8d2a39 to
1f183aa
Compare
msirringhaus
requested changes
Jan 8, 2026
Collaborator
msirringhaus
left a comment
msirringhaus
left a comment
There was a problem hiding this comment.
Looking good to me! Only one additional test would be nice, see inline comment.
Also note that I have not double checked with the spec, if the RpId-checks done here are sufficient. I'm taking your word for it :)
|
|
||
| #[test] | ||
| fn test_relying_party_id_rejects_ip_address() { | ||
| let result = RelyingPartyId::try_from("127.0.0.1"); |
Collaborator
There was a problem hiding this comment.
Can we have an IPv6-test as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Relying Party ID (RP ID) validation per the WebAuthn L3 spec.
Fixes #137