block: change __blkdev_issue_discard() return type to void #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: e7c375b |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
5121c4d to
4458758
Compare
Author
|
Upstream branch: 8b69055 |
blktests-ci
bot
force-pushed
the
series/1024711=>linus-master
branch
from
bf966b4 to
9ae67e7
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
4458758 to
6f43942
Compare
Author
|
Upstream branch: fd95357 |
blktests-ci
bot
force-pushed
the
series/1024711=>linus-master
branch
from
9ae67e7 to
c406463
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
6f43942 to
ec9caac
Compare
__blkdev_issue_discard() always returns 0, making all error checking at call sites dead code. The function simply stops allocating bios and returns 0. Discard operations are advisory/optimization, not critical. Some callers have dead error checking code expecting wrong return codes such as -ENOTSUPP when 0 is only returned. This patch changes __blkdev_issue_discard() return type to void and removes dead error checking code from all call sites: * Block layer: blk-lib.c: Remove return value, update blkdev_issue_discard() caller * Device mapper: dm-thin.c: Change issue_discard() to void, update both callers md.c: Simplify conditional to just check for NULL bio * NVMe target: io-cmd-bdev.c: Remove dead error handling and error_slba assignment * Filesystems: f2fs/segment.c: Preserve fault injection xfs/xfs_discard.c: Update both xfs_discard_extents() and xfs_discard_rtdev_extents() to remove dead error checks Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
Author
|
Upstream branch: c2f2b01 |
blktests-ci
bot
force-pushed
the
series/1024711=>linus-master
branch
from
c406463 to
e1e755e
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
ec9caac to
4a5ddea
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/linux-block/list/?series=1024711 irrelevant now for [{'archived': False, 'project': 241}] search patterns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: change __blkdev_issue_discard() return type to void
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1024711