fix(release): mark the Windows ARM64 MSI as Arm64 - #383
Merged
Merged
Conversation
jpackage (WiX 3.11) writes x64;1033 as the platform of every MSI, while the
ARM64 package embeds jpackage's ARM64 custom action DLL (wixhelper.dll).
Windows Installer runs that DLL in its x64 custom action host, which can't
load it, so installing fails with error 1723 ("A DLL required for this
install to complete could not be run"). Retarget the package to Arm64 with
schema 500 after jpackage builds it, so the DLL runs natively.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a release workflow step that, after jpackage builds the Windows ARM64 MSI, changes its summary information to target the
Arm64platform (Windows Installer schema 500), then reads it back to confirm.Why
The ARM64 MSI fails to install with Windows Installer error 1723: "There is a problem with this Windows Installer package. A DLL required for this install to complete could not be run." The portable
.zipworks.Inspecting the v0.0.3 release MSIs with msitools:
Binary.JpCaDll(jpackage'swixhelper.dll)windows-x64.msix64;1033windows-arm64.msix64;1033jpackage (with the runners' WiX 3.11) always writes
x64as the platform. ItsJpFindRelatedProductsandJpCheckInstallDircustom actions call intoJpCaDll. For an x64 package, Windows Installer runs that DLL in its x64 (emulated) custom action host, which can't load an ARM64 DLL, so every install fails. With the platform set toArm64, the DLL runs in the native ARM64 host. WiX's ownWixCAandWixUIWixcaare 32-bit and still run in the x86 host.The x64 MSI is unaffected: its DLL is x64 and imports only system libraries.
Notes for reviewers
windows-11-armrelease job, and neither PowerShell nor Windows Installer is available on macOS. It throws if the MSI isn'tx64;…before the edit orArm64;…after it, so a failure breaks the release job instead of shipping a bad package..zip.