feat(discover): disable Discover settings while discovery is switched off - #382
Merged
Merged
Conversation
… off Everything under the AI discovery switch follows it, and what was entered is kept. The status line and the settings summary say Off before naming anything missing, since nothing below can be changed then.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Since #378 discovery is on by default and the switch is how users opt out. Leaving the form editable while it's off suggested the settings were in effect.
Notes for reviewers
docs/ai-discovery.mdis updated.AiSettingsController.testConnectionstill supports a switched-off test; only the UI no longer offers it.enabled = false. Real pointer and touch input is blocked.Testing
./gradlew :app:shared:jvmTestpasses.AiDiscoverySettingsRenderTest.switchOff_disablesEverythingButTheSwitch: switching off disables the page access field, provider chips and access menu but not the switch; switching back on re-enables them and keeps the trusted sites.SettingsPageTest.discoverSummary_switchedOffWithoutKeys_saysOff.settings-discover-off, rendered with-Psnapshotsand checked.