ACLP: Remove content field from list alert channels response#675
Open
shkaruna wants to merge 1 commit intolinode:devfrom
Open
ACLP: Remove content field from list alert channels response#675shkaruna wants to merge 1 commit intolinode:devfrom
shkaruna wants to merge 1 commit intolinode:devfrom
Conversation
Author
|
@satkumar-akamai : Please review |
test/unit/objects/monitor_test.py
Outdated
| "/monitor/alert-channels/123/alerts", | ||
| ) | ||
| self.assertEqual(channels[0].alerts.alert_count, 0) | ||
| self.assertFalse(hasattr(channels[0], "content")) |
There was a problem hiding this comment.
is this assertion needed at all ? considering after removal this particular field will be irrelevant..
shkaruna
force-pushed
the
cleanup/list-channels-content
branch
from
2cf161b to
6f7cefb
Compare
shkaruna
requested review from
dawiddzhafarov and
psnoch-akamai
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove content field from list alert channels response.
contentfield is replaced withdetails.Ticket: DPS-41868
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Not applicable
How do I run the relevant unit/integration tests?
Prerequisites:
Clone the repository
Prepare environment (zsh / macOS)
Create and activate venv:
python3 -m venv .venv
source .venv/bin/activate
install deps
python -m pip install --upgrade pip
Install runtime dependencies:
pip3 install requests polling deprecated
Install dev/test extras
pip3 install -e '.[dev,test]'
test deps
pip3 install pytest mock httpretty pytest-rerunfailures
Unit test:
Run all unit tests:
python -m pytest test/unit -q
Run Monitor alert channels unit tests:
python -m pytest -q -s -v test/unit/objects/monitor_test.py::MonitorTest::test_alert_channels
=============================================================== test session starts ================================================================
platform linux -- Python 3.10.12, pytest-9.0.2, pluggy-1.6.0
rootdir: /home/shkaruna/sdk/linode_api4-python
configfile: pyproject.toml
plugins: anyio-4.12.1, rerunfailures-16.1
collected 1 item
test/unit/objects/monitor_test.py .
================================================================ 1 passed in 0.13s =================================================================
Integration test:
#if you have PAT token with write access only to Monitor and read for rest of the services for integration
export SKIP_E2E_FIREWALL=1 # optional: skip firewall to use fixture
export LINODE_TOKEN="YOUR_REAL_TOKEN" # required for integration
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
.
1 passed in 12.18s