Added support for increased Block Storage Volume limits #626
+161
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
ezilber-akamai
force-pushed
the
TPT-4040-block-storage-volume
branch
from
8f4ee7b to
6a2bba7
Compare
ezilber-akamai
changed the base branch from
dev
to
proj/block-storage-volume-limit-increase
…-block-storage-volume
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for increased Block Storage Volume limits by implementing dynamic device suffix generation. The key enhancement allows for up to 64 device attachments (previously limited to 8), with the actual limit scaled based on instance memory.
Key changes:
- Introduced
generate_device_suffixes()utility function to generate alphabetical suffixes beyond 'a-h' - Updated device limit calculation to scale between 8 and 64 based on instance memory
- Added comprehensive unit tests for the new suffix generation function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| linode_api4/util.py | Added generate_device_suffixes() function to generate alphabetical device suffixes with multi-character support (aa, ab, etc.) |
| linode_api4/objects/linode.py | Updated config_create() to use dynamic device limits and the new suffix generator |
| test/unit/util_test.py | Added unit tests validating suffix generation for 12, 30, and 60 device scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for increased Block Storage Volume limits.
✔️ How to Test
make test-unit