Skip to content

Replace 'secondary' with 'standby' in database instance configurations and tests #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Replace 'secondary' with 'standby' in database instance configurations and tests #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/fixtures/databases_instances.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"engine": "mysql",
"hosts": {
"primary": "lin-123-456-mysql-mysql-primary.servers.linodedb.net",
"secondary": "lin-123-456-mysql-primary-private.servers.linodedb.net"
"standby": "lin-123-456-mysql-primary-private.servers.linodedb.net"
},
"id": 123,
"instance_uri": "/v4/databases/mysql/instances/123",
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/databases_mysql_instances.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"engine": "mysql",
"hosts": {
"primary": "lin-123-456-mysql-mysql-primary.servers.linodedb.net",
"secondary": "lin-123-456-mysql-primary-private.servers.linodedb.net"
"standby": "lin-123-456-mysql-primary-private.servers.linodedb.net"
},
"id": 123,
"label": "example-db",
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/databases_postgresql_instances.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"engine": "postgresql",
"hosts": {
"primary": "lin-0000-000-pgsql-primary.servers.linodedb.net",
"secondary": "lin-0000-000-pgsql-primary-private.servers.linodedb.net"
"standby": "lin-0000-000-pgsql-primary-private.servers.linodedb.net"
},
"id": 123,
"label": "example-db",
Expand Down
6 changes: 3 additions & 3 deletions test/unit/groups/database_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_get_databases(self):
"lin-123-456-mysql-mysql-primary.servers.linodedb.net",
)
self.assertEqual(
dbs[0].hosts.secondary,
dbs[0].hosts.standby,
"lin-123-456-mysql-primary-private.servers.linodedb.net",
)
self.assertEqual(dbs[0].id, 123)
Expand Down Expand Up @@ -1280,7 +1280,7 @@ def test_get_mysql_instances(self):
"lin-123-456-mysql-mysql-primary.servers.linodedb.net",
)
self.assertEqual(
dbs[0].hosts.secondary,
dbs[0].hosts.standby,
"lin-123-456-mysql-primary-private.servers.linodedb.net",
)
self.assertEqual(dbs[0].id, 123)
Expand Down Expand Up @@ -1361,7 +1361,7 @@ def test_get_postgresql_instances(self):
"lin-0000-000-pgsql-primary.servers.linodedb.net",
)
self.assertEqual(
dbs[0].hosts.secondary,
dbs[0].hosts.standby,
"lin-0000-000-pgsql-primary-private.servers.linodedb.net",
)
self.assertEqual(dbs[0].id, 123)
Expand Down
8 changes: 4 additions & 4 deletions test/unit/objects/database_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def test_create_backup(self):
# We don't care about errors here; we just want to
# validate the request.
try:
db.backup_create("mybackup", target="secondary")
db.backup_create("mybackup", target="standby")
except Exception as e:
logger.warning(
"An error occurred while validating the request: %s", e
Expand All @@ -154,7 +154,7 @@ def test_create_backup(self):
m.call_url, "/databases/mysql/instances/123/backups"
)
self.assertEqual(m.call_data["label"], "mybackup")
self.assertEqual(m.call_data["target"], "secondary")
self.assertEqual(m.call_data["target"], "standby")

def test_backup_restore(self):
"""
Expand Down Expand Up @@ -410,7 +410,7 @@ def test_create_backup(self):
# We don't care about errors here; we just want to
# validate the request.
try:
db.backup_create("mybackup", target="secondary")
db.backup_create("mybackup", target="standby")
except Exception as e:
logger.warning(
"An error occurred while validating the request: %s", e
Expand All @@ -421,7 +421,7 @@ def test_create_backup(self):
m.call_url, "/databases/postgresql/instances/123/backups"
)
self.assertEqual(m.call_data["label"], "mybackup")
self.assertEqual(m.call_data["target"], "secondary")
self.assertEqual(m.call_data["target"], "standby")

def test_backup_restore(self):
"""
Expand Down
Loading