Python SDK for ACLP Alerts

[srbhaakamai]

📝 Description

Add Monitor alerting SDK + fix/harden monitor unit & integration tests

What does this PR do and why is this change necessary?

1. Adds full SDK support for Monitor alert definitions (create / get / update / delete) used by tests and examples.
2. Fixes serialization so JSONObject payloads containing Enum values serialize to primitives (prevents json.dumps errors).
3. Adds and updates unit fixtures and monitor unit tests; adds integration test coverage for create → update → delete alert definitions.
4. Makes integration fixtures resilient to tokens lacking certain scopes (skips firewall / DB provisioning when unauthorized) to allow running partial E2E locally.

This change is necessary because:

1. Unit tests were failing due to missing Enum serialization and missing mock helpers.
2. Integration tests would fail the whole session on tokens without cloud networking / DB scopes. Making fixtures skip when unauthorized lets developers iterate locally without privileged tokens.
3. Adding SDK monitor methods enables first-class programmatic control over alert definitions as documented in the API (POST /monitor/services/{service_type}/alert-definitions).

SDK additions (high level)

1. MonitorGroup methods (exposed on client.monitor):
2. alert_definitions(service_type, alert_id=None) — list or get
3. create_alert_definition(service_type, label, severity, type, description, channel_ids, trigger_conditions, rule_criteria, notification_groups, conditions)
4. update_alert_definition(service_type, alert_id, **fields) or client.monitor.update_alert_definition(...)
5. delete_alert_definition(service_type, alert_id)
6. alert_channels() — list alert channels
7. These map to the Monitor Alert Definition endpoints per docs: https://techdocs.akamai.com/linode-api/reference/post-alert-definition-for-service-type

Note:

1. severity must be integer.
2. trigger_conditions.polling_interval_seconds and evaluation_period_seconds must be API-allowed values (for these services 300s in our tests).
3. label/description must begin and end with an alphanumeric character.

✔️ How to Test

Clone the repository
Prepare environment (zsh / macOS)

✔️create & activate venv (recommended)

python3 -m venv .venv
source .venv/bin/activate

install deps
python -m pip install --upgrade pip

Install runtime dependencies:
pip3 install requests polling deprecated

Install dev/test extras
pip3 install -e '.[dev,test]'

test deps
pip3 install pytest mock httpretty pytest-rerunfailures

✔️How do I run the relevant unit tests?

cd <PROJECT_DIRECTORY>/linode_api4-python
Unit tests: python -m pytest test/unit -q
377 passed, 18 warnings in 0.79s (as on 8Oct2025) new test cases may be added later

Unit test for all monitor: python -m pytest test/unit/groups/monitor_api_test.py -q -s
3 passed, 1 warning in 0.10s

Single unit: python -m pytest test/unit/groups/monitor_api_test.py::MonitorAlertDefinitionsTest -q -s
2 passed, 1 warning in 0.09s

What are the steps to reproduce the issue or verify the changes?
Its a new feature, so end to end integration should suffice

✔️How do I run the relevant integration tests?

Integration tests (E2E):
Note:
#if you have PAT token with write access only to Monitor and read for rest of the services for integration
export SKIP_E2E_FIREWALL=1 # optional: skip firewall autouse fixture

export LINODE_TOKEN="YOUR_REAL_TOKEN" # required for integration
export SKIP_E2E_FIREWALL=1 # optional: skip firewall autouse fixture
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s

[ktnvaish22]

Approving with respect to ACLP Alerting API specifications, logic, test cases and integration testing.
Requesting API / Cloud Firewall team to review https://github.com/linode/linode_api4-python/pull/589/files#diff-70a344c4146b66b96b63999ccef7d16b311cceba86cfc2ac987a5edf3cffcdc3R82-R87

Thanks!

[Copilot]

Pull Request Overview

This PR adds comprehensive Monitor alerting SDK support to the Python API client, including CRUD operations for alert definitions, and improves test infrastructure to support both unit and integration testing scenarios.

• Adds full SDK support for Monitor alert definitions (create/get/update/delete operations)
• Fixes Enum serialization in JSONObject to prevent json.dumps errors
• Enhances test infrastructure with new fixtures and integration test resilience

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
test/unit/groups/monitor_api_test.py	Adds comprehensive unit tests for alert definition CRUD operations
test/unit/base.py	Adds missing mock helper methods (GET, PUT, DELETE) for MonitorClientBaseCase
test/integration/models/monitor/test_monitor.py	Adds E2E integration test for alert definition lifecycle
test/integration/conftest.py	Makes firewall fixture skippable for local development
test/fixtures/*.json	Adds JSON fixtures for alert definition mocking
linode_api4/objects/serializable.py	Fixes Enum serialization to prevent JSON encoding errors
linode_api4/objects/monitor.py	Adds comprehensive data classes for alert definitions and channels
linode_api4/linode_client.py	Exposes MonitorGroup on MonitorClient for alert operations
linode_api4/groups/monitor.py	Implements alert definition CRUD methods

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[srbhaakamai]

FIxed issues with CI and comments from Copilot AI

[yec-akamai]

To fix the lint issue, you can run make isort and make lint locally

[yec-akamai]

Thank you for the contribution! You probably need to make changes around the implementation of AlertDefinition

[srbhaakamai]

@zliang-akamai @jriddle-linode @vshanthe request please review this and provide feedback and approval.

any updates on 2nd review and approval?

[Copilot]

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[srbhaakamai]

@zliang-akamai the copilot comments are addressed , unit and integration test done and commited to this.

[srbhaakamai]

Any updates on this review ?

[lgarber-akamai]

This looks great! Just one thing and we should be set

[srbhaakamai]

@zliang-akamai the review comments are addressed in all applicable places. Please review/approve furrther.

[Copilot]

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The inline comment '# <-- Close the rule dictionary here' is unnecessary as it simply states what the closing brace does. Remove this comment as it adds no value.

Suggested change

	} # <-- Close the rule dictionary here
	}

[Copilot]

The comment 'max time alert should take to update' is incomplete and doesn't explain what the code below it does. Either expand this to explain the cleanup logic or remove it.

Suggested change

# max time alert should take to update

[Copilot]

The field 'aggregate_function' accepts both AggregateFunction enum and str, but defaults to an empty string. This is inconsistent since the AggregateFunction enum doesn't have an empty string value. Consider using None as the default or making it Optional[Union[AggregateFunction, str]].

Suggested change

	aggregate_function: Union[AggregateFunction, str] = ""
	aggregate_function: Optional[Union[AggregateFunction, str]] = None

[zliang-akamai]

Suggested change

	) -> Union[PaginatedList]:
	) -> PaginatedList:

You wouldn't need Union if there is only one type...

[zliang-akamai]

It seems the Property constructor call needs an argument of json_object=TriggerConditions, right?

Suggested change

	"trigger_conditions": Property(mutable=True),
	"trigger_conditions": Property(mutable=True, json_object=TriggerConditions),