Skip to content

feat: use smart git-http-server#3103

Draft
CasLubbers wants to merge 11 commits intomainfrom
APL-1704
Draft

feat: use smart git-http-server#3103
CasLubbers wants to merge 11 commits intomainfrom
APL-1704

Conversation

@CasLubbers
Copy link
Copy Markdown
Contributor

📌 Summary

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I have successfully deployed. ✅

  2. I like the fact that it is using istio sidecar, so mTLS can be set between communicating parties. ✅

  3. I am wondering if mtls should be enforced though ⚠️

  4. I was also able to clone the repo::white_check_mark:

kubectl port-forward --namespace git-server svc/git-server 9090:80
git clone http://127.0.0.1:9090/otomi/values.git
kubectl get secret git-server-credentials -n git-server -o jsonpath='{.data.password}'
  1. After enabling gitea things get messy, so fine tuning needs to be done so the platform does not try to switch to gitea. ⚠️

repoName: otomi/values.git

image:
repository: docker.io/clubbers1892/simple-git-server
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once PoC is approved we will host it at docker.io/linode

pullPolicy: IfNotPresent

persistence:
size: 1Gi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

256Mi should be more than enough


releases:
- name: git-server
installed: {{ not ($a | get "gitea.enabled") }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, make it independent from git.
The git-server is going to be default mode. It should be possible to switch it to Gitea but that falls into to BYO git procedure and should not differ from switching to Github or other 3rd party provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants