Conversation
CasLubbers
requested changes
Mar 31, 2026
Contributor
CasLubbers
left a comment
CasLubbers
left a comment
There was a problem hiding this comment.
The implementation is not wrong, but we already have a similar function for this: ensureTeamGitOpsDirectories https://github.com/linode/apl-core/blob/main/src/common/utils.ts#L218
We can consolidate the logic and re-use it for the manifests folder. I think it would also be good to call it in the same place.
j-zimnowoda
reviewed
Apr 1, 2026
j-zimnowoda
reviewed
Apr 1, 2026
j-zimnowoda
reviewed
Apr 1, 2026
j-zimnowoda
reviewed
Apr 1, 2026
j-zimnowoda
reviewed
Apr 1, 2026
j-zimnowoda
requested changes
Apr 1, 2026
j-zimnowoda
reviewed
Apr 2, 2026
j-zimnowoda
reviewed
Apr 2, 2026
src/common/utils.ts
Outdated
| if (!existsSync(dirname(keepFilePath))) { | ||
| await $`mkdir -p ${dirname(keepFilePath)}` | ||
| } | ||
| await ensureDirectoryWithGitkeepAsync(dirname(keepFilePath), deps) |
Contributor
There was a problem hiding this comment.
is forwarding deps object necessary here?
j-zimnowoda
reviewed
Apr 2, 2026
src/operator/apl-operator.test.ts
Outdated
| describe('AplOperator', () => { | ||
| let aplOperator: AplOperator | ||
| let defaultConfig: AplOperatorConfig | ||
| const fs = require('fs') |
Contributor
There was a problem hiding this comment.
I am not sure if this is the best way to mock it. We use deps as dependency injection pattern which makes packing deps very easy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensure that the manifests folders are always present in the values with a .gitkeep file.