Repository navigation
Fix Total Column display and update LinkField display - #437
Merged
Merged
Conversation
richardiphillips
requested review from
a team
and
a balanced review from Copilot
October 5, 2026 14:38
RossStewart
approved these changes
Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Enabled links currently use the disabled-text color, and the expanded LinkField behavior needs targeted coverage.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds total-column styling to reports and refreshes LinkField with an outlined, tooltip-enabled presentation.
Changes:
- Bold report columns identified by
headers.totalColumns, with tests and Storybook coverage. - Redesign
LinkFieldand add tooltip/icon behavior. - Update release and dependency metadata.
| File | Description |
|---|---|
src/components/ReportDataGrid.stories.js |
Adds a total-column story. |
src/components/ReportDataGrid.js |
Styles configured total columns. |
src/components/LinkField.js |
Introduces the outlined link presentation. |
src/components/__tests__/ReportDataGrid.test.js |
Tests total-column styling. |
package.json |
Updates version and dependencies. |
package-lock.json |
Synchronizes dependency resolution. |
CHANGELOG.md |
Documents version 34.4.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <OutlinedInput | ||
| sx={{ | ||
| paddingTop: 0, | ||
| color: 'text.disabled', |
Comment on lines
+124
to
+125
| inputComponent={LinkValue} | ||
| slotProps={{ input: { external, to, openLinksInNewTabs, label, toolTip } }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.