Repository navigation
search tweak - #434
Merged
Merged
search tweak#434
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage for modal opening when results remain visible.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds an optional showResultsList prop to suppress built-in Search results while preserving search behavior.
Changes:
- Added
showResultsList, defaulting totrue. - Prevented modal opening when results are suppressed.
- Added tests and bumped package/changelog versions.
| File | Summary |
|---|---|
src/components/Search.js |
Implements conditional result rendering and modal behavior. Storybook args should expose the new prop. |
src/components/__tests__/Search.test.js |
Tests suppressed results; coverage should also preserve default modal behavior. |
package.json |
Bumps package version to 34.2.0. |
package-lock.json |
Synchronizes package metadata. |
CHANGELOG.md |
Documents the new option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| onResultSelect, | ||
| resultLimit = null, | ||
| resultsInModal = false, | ||
| showResultsList = true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.