fix: clarify ingress mode header warning#2128
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Problem\n\nThe ingress mode warning says to remove the header, but the same page later shows Traefik and other ingress examples adding that header for internal routing. That contradiction is live on linkerd.io and confuses readers about the actual security requirement.\n\nSolution\n\nClarify that ingress mode must strip untrusted incoming headers from client traffic, while still allowing the ingress controller to add its own header for requests to in-cluster services. Apply the wording fix to the current docs, edge docs, and 2.18 docs.\n\nFixes linkerd#1837 Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1837
Bug
The live ingress docs say ingress mode must remove
l5d-dst-override, but the same page later tells Traefik to add it. Kinda mixed signals, and easy to read the wrong way.Fix
Clarify that ingress mode must strip
l5d-dst-overridefrom incoming client traffic, while still allowing the ingress controller to add its own header for in-cluster routing.Repro
https://linkerd.io/docs/tasks/using-ingress/Checks
make lintPATH="/tmp/bin:/tmp/linkerd-tools/node_modules/.bin:$PATH" make check