[controller] [server] extend rt versioning to system stores #2264

arjun4084346 · 2025-11-04T23:35:15Z

Problem Statement

This pull request extend RT Versioning introduced for user stores in PR#1555, PR#1657 to system stores.
To find the right RT name, we need to now have Store object of a system store, which is the why we have added a unified store resolver for system store access in various components.

System Store Resolution Improvements

Added a getStore method to DaVinciBackend to correctly resolve system stores and user stores, improving how system store attributes are accessed.

System Store Topic Handling

Modified logic in StoreIngestionTask to use the store resolver for system store topic name resolution, ensuring correct topic handling for meta stores.
Updated utility usage to fetch real-time topic names from Store objects rather than raw strings, improving correctness.

Solution

Code changes

Added new code behind a config. If so list the config names and their default values in the PR description.
Introduced new log lines.
- Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

Code has no race conditions or thread safety issues.
Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

New unit tests added.
New integration tests added.
Modified or extended existing tests.
Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

No. You can skip the rest of this section.
Yes. Clearly explain the behavior change and its impact.

Copilot

Pull Request Overview

This PR appears to be a work-in-progress change that modifies real-time topic handling logic and adds debugging code. The main changes include updating a log message to include the real-time topic name, modifying the composeRealTimeTopic method to delegate to its versioned counterpart, and temporarily altering the isRTVersioningApplicable logic.

Modified composeRealTimeTopic(String) to delegate to the versioned method with version 1
Changed isRTVersioningApplicable to always return true instead of checking system store types
Added debugging statements with System.out.println calls

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
VeniceHelixAdmin.java	Enhanced log message to include the real-time topic name for better debugging
Utils.java	Modified real-time topic composition and versioning applicability logic with commented-out code and debug statements
MetaStoreWriter.java	Added unused variable declaration for old topic name
PubSubTopicImpl.java	Added debugging code with empty print statement for specific topic pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java

Copilot

Pull Request Overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...s/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceParentHelixAdmin.java

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java

clients/da-vinci-client/src/test/java/com/linkedin/davinci/DaVinciBackendTest.java

services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

...mon/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreVeniceWriterCache.java

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java

Copilot

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

.../venice-common/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreWriter.java

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

...mon/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreVeniceWriterCache.java

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

...mon/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreVeniceWriterCache.java

...-controller/src/main/java/com/linkedin/venice/controller/ParticipantStoreClientsManager.java

sixpluszero · 2025-11-14T06:57:48Z

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

    return storeRepository;
  }

+  public final Object getStore(String storeName) {


This logic scattered in here is not great IMO.
I think the main purpose to extract push status store's RT version right? Then can we just instead pass ReadOnlyStoreRepository interface into the the PushStatusStoreWriter constructor, and extract the user store object -> extract system store info -> get largest RT version when preparing VW? I think this will make the logic hidden inside the corresponding object.
Same comment goes to MetaStoreWriter.

I read the code again. I think even with the discussion we had offline, I think this method is still not great as (1) this is internal usage and we should not expose as public and leave it in this class (2) the usage is limited.
Also, I see meta store writer and push status store writer is having duplicate logic of getting RT topic from the Store-like object.
Can we move this method to Util class, and also create a method to extract that duplicate logic from both class to be a getRealtimeTopicNameFromStore util method?

haoxu07 · 2025-11-14T22:47:58Z

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

+      Store store = storeResolver.apply(metaStoreName);
+      int largestUsedRTVersionNumber;
+      VeniceSystemStoreType type = VeniceSystemStoreType.getSystemStoreType(store.getName());
+      if (type != null && store.isSystemStore()) {


If the store is not system store, should we just return null, as this function is for system store only.

This if block is actually to distinguish b/w user system store and zkShared system store

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/venice-common/src/main/java/com/linkedin/venice/system/store/MetaStoreWriter.java

.../venice-common/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreWriter.java

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

...mon/src/main/java/com/linkedin/venice/pushstatushelper/PushStatusStoreVeniceWriterCache.java

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java

internal/venice-test-common/src/integrationTest/resources/log4j2-test.xml

...grationTest/java/com/linkedin/venice/controller/TestParentControllerWithMultiDataCenter.java

services/venice-controller/src/main/java/com/linkedin/venice/controller/Admin.java

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sixpluszero · 2026-01-05T20:01:31Z

...nci-client/src/main/java/com/linkedin/davinci/kafka/consumer/KafkaStoreIngestionService.java

      if (storeIngestionTask.isHybridMode() && partitionConsumptionState.isEndOfPushReceived()
          && partitionConsumptionState.getLeaderFollowerState() == LeaderFollowerStateType.LEADER) {
-        ingestingTopic = pubSubTopicRepository.getTopic(Utils.composeRealTimeTopic(storeName));
+        ingestingTopic = pubSubTopicRepository.getTopic(Utils.getRealTimeTopicName(store));


Does this util come with a fallback? I think it is important to have a fallback inside the util method so that it does not throw exception in a random place

sixpluszero · 2026-01-05T20:45:36Z

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

    return storeRepository;
  }

+  public final Object getStore(String storeName) {


I read the code again. I think even with the discussion we had offline, I think this method is still not great as (1) this is internal usage and we should not expose as public and leave it in this class (2) the usage is limited.
Also, I see meta store writer and push status store writer is having duplicate logic of getting RT topic from the Store-like object.
Can we move this method to Util class, and also create a method to extract that duplicate logic from both class to be a getRealtimeTopicNameFromStore util method?

Copilot AI review requested due to automatic review settings November 4, 2025 23:35

arjun4084346 marked this pull request as draft November 4, 2025 23:35

Copilot AI reviewed Nov 4, 2025

View reviewed changes

internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java Show resolved Hide resolved

internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java Outdated Show resolved Hide resolved

arjun4084346 force-pushed the rtsystemstore branch 7 times, most recently from e3f7077 to 6498e12 Compare November 13, 2025 11:04

arjun4084346 marked this pull request as ready for review November 13, 2025 11:04

Copilot AI review requested due to automatic review settings November 13, 2025 11:04

Copilot started reviewing on behalf of arjun4084346 November 13, 2025 11:05 View session

Copilot finished reviewing on behalf of arjun4084346 November 13, 2025 11:07

Copilot AI reviewed Nov 13, 2025

View reviewed changes

arjun4084346 changed the title ~~[controller] extend rt versioning to system stores~~ [controller] [server] extend rt versioning to system stores Nov 13, 2025

Copilot AI review requested due to automatic review settings November 13, 2025 21:56

Copilot started reviewing on behalf of arjun4084346 November 13, 2025 21:57 View session

Copilot finished reviewing on behalf of arjun4084346 November 13, 2025 22:00

Copilot AI reviewed Nov 13, 2025

View reviewed changes

sixpluszero reviewed Nov 14, 2025

View reviewed changes

haoxu07 reviewed Nov 14, 2025

View reviewed changes

arjun4084346 force-pushed the rtsystemstore branch from 3f62e17 to 7e9ab58 Compare December 8, 2025 07:47

Copilot AI review requested due to automatic review settings December 8, 2025 16:35

arjun4084346 force-pushed the rtsystemstore branch from 7e9ab58 to 4da90c1 Compare December 8, 2025 16:35

Copilot started reviewing on behalf of arjun4084346 December 8, 2025 16:35 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

linkedin deleted a comment from Copilot AI Dec 8, 2025

arjun4084346 force-pushed the rtsystemstore branch from 4da90c1 to d286572 Compare December 9, 2025 10:16

Copilot AI review requested due to automatic review settings December 9, 2025 11:20

arjun4084346 force-pushed the rtsystemstore branch from d286572 to a509157 Compare December 9, 2025 11:20

Copilot started reviewing on behalf of arjun4084346 December 9, 2025 11:21 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

arjun4084346 force-pushed the rtsystemstore branch from a509157 to f859323 Compare December 9, 2025 12:17

linkedin deleted a comment from Copilot AI Dec 9, 2025

Copilot AI review requested due to automatic review settings December 9, 2025 17:17

arjun4084346 force-pushed the rtsystemstore branch from f859323 to 001bf7e Compare December 9, 2025 17:17

Copilot started reviewing on behalf of arjun4084346 December 9, 2025 17:17 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

linkedin deleted a comment from Copilot AI Dec 9, 2025

arjun4084346 added 2 commits January 5, 2026 12:02

extend rt versioning to system stores

4296ca1

.

ae75269

arjun4084346 force-pushed the rtsystemstore branch from 001bf7e to ae75269 Compare January 5, 2026 20:03

sixpluszero reviewed Jan 5, 2026

View reviewed changes

[controller] [server] extend rt versioning to system stores #2264

Are you sure you want to change the base?

[controller] [server] extend rt versioning to system stores #2264

Uh oh!

Conversation

arjun4084346 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

Code changes

Concurrency-Specific Checks

How was this PR tested?

Does this PR introduce any user-facing or breaking changes?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sixpluszero Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

sixpluszero Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

haoxu07 Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

arjun4084346 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

arjun4084346 commented Nov 4, 2025 •

edited

Loading