Repository navigation
Consolidate links-queue npm exports and repair OIDC release pipelines - #56
Merged
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #55
konard
marked this pull request as ready for review
November 16, 2026 00:50
Member
Author
Working session summaryUpdated PR #56 and marked it ready for review.
Live publication remains blocked by unavailable registry-owner access for bootstrap and trusted-publisher setup. npm/crates publication and subsequent secret-free releases remain unverified. The PR is unmerged, and the issue is not fully complete. This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (155.0K + 9.8M cached) input tokens, 39.1K output tokens, $3.163934 cost 🤖 Models used:
📎 Log file uploaded as Gist (957KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
This reverts commit 9d055a6.
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Linked issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates JavaScript distribution into
links-queueand repairs the existing npm/crates.io release paths. Core, CLI, server, and client entry points remain available; integrations are imported fromlinks-queue/express,links-queue/fastify,links-queue/hono, andlinks-queue/nestjs.Fixes #55
Fixes #53
Changes
requireand Hono's global constructor assumption, which prevented the exposed router factories from working.npm publish --access public --provenance, use the manifest version, and verify the exact version exists before reporting success. Registry errors and rejected publishes fail the job. Preserve bounded retries, checking registry visibility after a lost connection so an accepted upload is not repeated.TEXT_ENCODINGS.unionunder Node 20 (downloaded log lines 8634–8652). Keep the Node 20 runtime test matrix for consumer compatibility.Reproduction and automated verification
Before this change the root manifest is
links-queue-jsand has no integration subpath exports. Installing it cannot provide the requestedlinks-queue/*imports. Runbash experiments/issue-55-package-regression.shto run the new tarball test against pre-change main: it fails because separate integration manifests are shipped.After the change:
npm run test:packageinjs/: passes. Packs and installs into an isolated temporary consumer, imports core/server/client before installing framework peers, then resolves all four integrations, constructs Express/Hono routers, registers the Fastify plugin, exercises a NestJS service, and checks TypeScript subpath resolution. Runs in CI as Verify npm Package with finite test/job timeouts.node --test js/scripts/publish-to-npm.test.mjs: 6 passing cases for canonical-only publication, registry verification, reruns, rejected/invisible publishes, and registry failures.node scripts/version-and-commit.mjs --helpon Node 24 in both workflows to verify dependency startup without creating release commits or tags.node --test rust/scripts/crates-io.test.mjs: 11 passing cases for the existing crates.io publish helper.git diff --check: pass locally. Full runtime/OS tests and Rust builds are left to CI to respect the container's memory budget.Unfinished acceptance criteria: live publication is blocked
This PR is not a completed registry rollout and remains unmerged. At investigation time:
npm view links-queue versionreturns E404. All five split npm names also return E404, which satisfies the requirement to leave them unpublished.npm whoamireturns ENEEDAUTH. No Cargo credential file or repository Actions secrets are present. A GitHub repository credential cannot bootstrap registry ownership or register trusted publishers.cargo search links-queue --limit 5returns no matching crate. Direct crates.io API access from this environment returns HTTP 403, so the search and workflow evidence are retained separately from that API limitation.The blocked criteria are successful
npm view links-queue version, the crate appearing incargo searchafter workflow publication, and live confirmation of secret-free subsequent releases. An authenticated registry owner must bootstrap/register the publishers described in the release guide, then run successful release workflows on main. No credentials have been requested, stored, or added by this PR. Passing PR CI does not substitute for these unmet criteria.CI investigation
The initial Bun/Windows job discovered the new Node packaging test and failed
with
Unexpected end of filewhen its shell split inline JavaScript (job, downloaded log lines 183–225). The probe now uses a module file and executable calls without a shell; Bun runs its existing suite undertests/, while the dedicated Node packaging job covers the npm artifact. Superseded runs were explicitly cancelled to avoid wasting runner resources. Final validation is tracked against the current PR head, rather than superseded run results.At final code commit
5d27a990a634fbd33463c89bcd7a7cd77ab7c962, the Rust workflow passes on Linux, Windows, and macOS, including package build/publish dry run and benchmarks. The JavaScript workflow passes lint, installed-tarball verification, coverage, and all nine Node/Bun/Deno runtime combinations on Linux, Windows, and macOS. Both workflows started after this commit and completed successfully. The working tree is clean, remote main (2612654) is included, and the PR remains unmerged with the live publication criteria above unfinished.