feat(NO-TASK): Allow the types the release-please standard sections - #9
Open
aaronware wants to merge 1 commit into
Open
feat(NO-TASK): Allow the types the release-please standard sections#9aaronware wants to merge 1 commit into
aaronware wants to merge 1 commit into
Conversation
release-please groups changelog sections strictly by commit type - there is no scope key in its schema - so wp-plugin and wp-theme have to be types, not only scopes, for WordPress plugins and themes to get a changelog section each rather than collapsing into `update`. linchpin/renovatebot-config emits them. deps and platform are allowed for the fleet's history, which contains ~150 such commits, and because either reads better than `build` for a hand-written dependency commit. renovatebot-config itself now routes that traffic through build(npm) and build(composer). The scope slot under the WordPress types names where the package came from: `wporg` for anything public - wp-packages.org and wpackagist.org are two routes to the same wordpress.org packages - and `linchpin` for packagist.linchpin.com. release-please-config.json is brought onto the shared standard at the same time, which is also what fixes the two defects that standard exists to prevent: `add` and `remove` had no section here, so those commits were dropped from changelogs entirely. @linchpinagency/release-please-config asserts that its section list equals the type list here, so the two can no longer drift apart unnoticed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the commit types that
@linchpinagency/release-please-configgives changelog sections to, and brings this repo's ownrelease-please-config.jsononto that standard.Why
wp-pluginandwp-themehave to be typesrelease-please groups changelog sections strictly by commit type.
changelog-sections[].typeis the only key its schema offers, and the schema isadditionalProperties: false— there is no scope key.So
update(wp-plugin)andupdate(wp-theme)— the formrenovatebot-config@652b5ademits today — share the typeupdateand collapse into a single changelog section. Promoting them to types gives WordPress plugins and themes a section each:The scope now names where the package came from:
wporgfor anything public (wp-packages.org and wpackagist.org are two routes to the same wordpress.org packages),linchpinfor packagist.linchpin.com.Why
depsandplatformare allowedNot because Renovate emits them — it no longer does, routing that traffic through
build(npm)andbuild(composer). They're allowed because the fleet's history contains ~150 such commits, and because either reads better thanbuildfor a hand-written dependency commit.What changed
index.jsTYPESgainsdeps,platform,wp-plugin,wp-theme;DEP_SCOPESgainswporg,linchpinindex.test.jsREADME.mdwporg/linchpindistinctionrelease-please-config.jsonWhat this fixes
A crawl of 31 repos found the section lists and this type list had drifted apart in both directions:
addandremoveare valid types here but had no section anywhere — those commits were dropped from every changelog silentlytweakhad a section in 25 repos but was never a valid type, so no commit could reach itrelease-please-config's test suite now asserts its section list equals this type list, so the two can't drift apart unnoticed again.Review focus
index.js:3-15— the type and scope lists, and whetherdeps/platformare worth keeping now that Renovate no longer emits them.Both prefix forms lint, so PRs already open with
update(wp-plugin)keep passing through the transition.