Repository navigation
fix: netlify - Resolve direct navigation and refresh 404s - #15
netlify-coding[bot] wants to merge 1 commit into
Conversation
…ce01f1655746ee42)
✅ Deploy Preview for thisonetimeonacid ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verdict: technically mergeable, but merge readiness has not yet been demonstrated. Audited head: Verified current state
What remains before merge
Documentation and tracking
After an authorised merge Repeat routing and asset checks on production, record the production deployment URL, and only then close #3 and GitHub #3. Production verification is a post-merge acceptance step, not a prerequisite for merging. Keep the lockfile/overrides mismatch separate and provide its tracking reference. Conclusion: successful deployment and redirect processing support the fix, but do not complete functional acceptance or substitute for review. This is a metadata/evidence audit, not a code approval. |
Bugfix Pull Request
Linked issues
Relates to GitHub issue #3.
Addresses Linear TOA-4, currently Todo. Keep both issues open until deployed acceptance and production verification are recorded. These are references, not auto-closing links; no formal Linear PR relationship is currently recorded.
Issue #3’s “No implementation PR” wording is stale. Updating either issue is outside this metadata proposal.
Context
ac620c461fa0809abffd333e56639136db325729.Implementation agent, as recorded in the original PR: Claude.
GitHub author:
netlify-coding[bot]. Model attribution is not supplied.Original agent run.
Original captured prompt, truncated:
The implementation addresses the reported configuration problem. Deployed functional acceptance remains unverified. Pre-fix runtime findings and local validation below remain attributed to the implementation agent.
Reproduction
dist/_redirects./journal,/journal/berlin-morning-lightand/ebook.Expected: valid redirect processing; supported routes render the intended pages; real assets retain their content types; unknown routes render NotFound.
Actual before the fix, agent-reported:
/returned 200, while affected routes and unknown routes returned Netlify 404 responses. The build reportedly produced an unreadable redirect directory with no processed rules.Root Cause
/* /index.html 200, not application code.dist/_redirects/main.tsx, causingCould not read redirects file: /opt/build/repo/dist/_redirects. Generated output and historical runtime behaviour were not independently reproduced in this metadata review.npm run build, publish directorydist, production branchmain.netlify.tomlis tracked at the implementation commit. The existing src/app/netlify.toml was reportedly inactive under that root-based configuration. Dashboard settings were not independently inspected.Fix Summary
8fd679b385c11d6ddd7561d8c0ac48b0efd0c22e; comments and the fallback rule are unchanged.!) or TOML redirect rule. Existing static-file precedence is intended to remain unchanged; deployed asset behaviour still requires acceptance evidence.Unchanged: build command, publish directory, vite.config.ts, React/Tailwind plugins,
figmaAssetResolver(), package manager, runtimes, environment variables, headers, caching and artwork.Nested TOML remains untouched: moving it could activate unrelated headers and runtime settings outside issue #3’s scope.
Verification
Local validation reported by the implementation agent, not independently repeated:
netlify dev, outside the repository without rebuilding./, the affected routes and/no-such-routereturned 200text/html; React Router’s*route reportedly renderedNotFoundPage.application/javascriptandtext/css, rather than fallback HTML.Independently retrieved check and review evidence:
Outstanding before merge:
dist/_redirectsis a regular file containing the intended fallback.After authorised merge:
Repeat checks on production and record the production deployment URL and results before closing either linked issue.
No automated tests were added. package.json has no test, lint or typecheck script at the implementation commit. Record manual validation rather than marking automated testing complete.
Risk & Rollback
Notes and follow-ups:
/assets/missing.jsreturns fallback HTML with 200; real assets were reportedly unaffected locally. Deployed negative-case evidence remains outstanding.agent-website-ee42lacks the documentedfix/prefix. No branch change is proposed.Changelog
Added
None.
Changed
None.
Fixed
Removed
None.
Checklist (Global DoD / PR)
Only contributor-guide/changelog updates are confirmed complete. Documentation inconsistency, QA, review and release completion remain unresolved. Checklist wording follows the template; applicability must be assessed for this React/Vite repository.
Status checked 5 October 2026: contributor-guide/changelog updates, preview availability and redirect-processing success are confirmed. Clean install/build, generated redirect artefact verification, deployed browser/device QA, accessibility/security review, actual review approval, risk/rollback and production acceptance remain outstanding. CodeRabbit skipped review; successful checks do not establish approval. Linked issues remain open.
Proposed closing comment for #3 (post only after production verification)
Future draft only; do not post now. Replace placeholders with verified evidence and confirm separate lockfile tracking before using the final sentence.