LCORE-4188: Update lightspeed-providers by maysunfaisal · Pull Request #2730 · lightspeed-core/lightspeed-stack

maysunfaisal · 2026-09-17T18:48:46Z

Description

Updates the lightspeed-providers dependency to include the Solr KNN query fix from lightspeed-providers#171.

This change:

Updates the providers git submodule from faf6a89 to 3d01e7a.
Updates LIGHTSPEED_PROVIDERS_COMMIT in the Lightspeed Stack Containerfile to the same commit.
Updates the Konflux providers archive URL and SHA-256 checksum.

The providers fix generates valid Solr KNN syntax ({!knn ...}), allowing OKP vector retrieval to return the relevant documentation instead of silently returning no matches.

Type of change

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

Assisted-by: Codex (OpenAI)
Generated by: Codex (OpenAI)

Related Tickets & Documents

Related Issue: LCORE-4188
Depends on: lightspeed-providers#171

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Automated and build verification

Confirmed the submodule, Containerfile, and Konflux archive all reference commit 3d01e7a67f1321decaa1f6edb9390cf0ff1ebb4c.
Independently verified the Konflux archive checksum: sha256:6735c1349f35f7ccd28d4898a6ad0516acbb5ab33fd48177633d09a59c34f2b1.
uv run make format — passed.
uv run make test-unit — 3,558 passed, 1 skipped; 91.22% coverage.
Pre-commit secret scan — passed.
Built and pushed quay.io/maysunfaisal/lightspeed-stack:lcore-4188-solr-knn.

OpenShift integration verification

Deployed RHDH with Intelligent Assistant and OKP using the custom Lightspeed Stack image.
Confirmed RHDH, Lightspeed Core, PostgreSQL, and OKP were ready with zero restarts.
Confirmed Lightspeed Core reported All providers are healthy.
Queried the Intelligent Assistant for the RHDH installation documentation for AKS.
Confirmed OKP returned the relevant AKS documentation and the assistant generated an AKS-specific installation response with documentation citations.

Update the providers submodule and container/Konflux pins to include the corrected Solr KNN query syntax. Co-authored-by: Codex <codex@openai.com>

coderabbitai · 2026-09-17T18:49:10Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7b67fce9-847f-4ca6-b90a-0ec8f3a4d20e

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8f8db and 9a4976e.

📒 Files selected for processing (3)

.konflux/artifacts.lock.yaml
deploy/lightspeed-stack/Containerfile
providers

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (22)

GitHub Check: E2E: library / ci / shields
GitHub Check: E2E: library / ci / skills
GitHub Check: E2E: library / ci / rbac
GitHub Check: E2E: server / ci / shields
GitHub Check: E2E: server / ci / tls
GitHub Check: E2E: library / ci / other
GitHub Check: E2E: library / ci / authorized
GitHub Check: E2E: server / ci / default
GitHub Check: E2E: library / ci / default
GitHub Check: E2E: library / ci / mcp
GitHub Check: E2E: server / ci / mcp
GitHub Check: E2E: server / ci / other
GitHub Check: E2E: server / ci / skills
GitHub Check: E2E: server / ci / authorized
GitHub Check: E2E: server / ci / rbac
GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
GitHub Check: integration_tests (3.12)
GitHub Check: integration_tests (3.13)
GitHub Check: build-pr
GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request

🧰 Additional context used

📓 Path-based instructions (1)

Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.

📄 CodeRabbit inference engine (Custom checks)

Files:

providers
deploy/lightspeed-stack/Containerfile

🔇 Additional comments (3)

providers (1)

1-1: LGTM!

deploy/lightspeed-stack/Containerfile (1)

40-40: LGTM!

.konflux/artifacts.lock.yaml (1)

6-7: 🗄️ Data Integrity & Integration

The archive for commit 3d01e7a67f1321decaa1f6edb9390cf0ff1ebb4c produces SHA-256 6735c1349f35f7ccd28d4898a6ad0516acbb5ab33fd48177633d09a59c34f2b1, so the checksum is correct.

Walkthrough

The pull request updates the lightspeed-providers pin to commit 3d01e7a67f1321decaa1f6edb9390cf0ff1ebb4c in the subproject pointer, Containerfile, and Konflux artifact lock.

Changes

lightspeed-providers pin update

Layer / File(s)	Summary
Align provider commit and artifact checksum `.konflux/artifacts.lock.yaml`, `deploy/lightspeed-stack/Containerfile`, `providers`	The subproject pointer and Containerfile build argument use the new commit. The artifact lock updates the download URL and matching SHA-256 checksum.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: anik120, syedriko

Merge Risk: ⚪ Minimal · up to 9a497

No actionable merge-blocking risk remains in this pin-only update.

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity	✅ Passed	No meaningful performance regression is introduced. The reviewed diff only updates provider pins, the artifact checksum, and the container commit argument. The selected provider range changes Solr que…
Security And Secret Handling	✅ Passed	PASSED. The PR changes only the provider pin, container pin, and checksum. The exact upstream comparison contains only Solr KNN query construction, a unit test, dependency-lock updates, and a workflow…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: updating the lightspeed-providers submodule and related pins.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

✨ Simplify code

Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

maysunfaisal · 2026-09-17T22:03:49Z

/retest

red-hat-konflux-kflux-prd-rh02 · 2026-09-17T22:03:54Z

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

maysunfaisal · 2026-09-17T22:08:08Z

/test

openshift-ci · 2026-09-17T22:08:11Z

@maysunfaisal: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

asimurka · 2026-09-18T06:27:17Z

@maysunfaisal Thanks for this but we're planning to make additional changes to providers repository before GA release. I'm keeping in my mind to update hashes after the final change lands in providers repo.

maysunfaisal · 2026-09-18T13:54:23Z

@maysunfaisal Thanks for this but we're planning to make additional changes to providers repository before GA release. I'm keeping in my mind to update hashes after the final change lands in providers repo.

@asimurka thanks, just to confirm if we're talking about 0.7.0 GA?

asimurka · 2026-09-18T13:55:48Z

Yes

LCORE-4188: Update lightspeed-providers

9a4976e

Update the providers submodule and container/Konflux pins to include the corrected Solr KNN query syntax. Co-authored-by: Codex <codex@openai.com>

Navigation Menu

LCORE-4188: Update lightspeed-providers - #2730

LCORE-4188: Update lightspeed-providers#2730
maysunfaisal wants to merge 1 commit into
lightspeed-core:mainfrom
maysunfaisal:LCORE-4188-update-lightspeed-providers

maysunfaisal commented Sep 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

maysunfaisal commented Sep 17, 2026

Uh oh!

red-hat-konflux-kflux-prd-rh02 Bot commented Sep 17, 2026

Uh oh!

maysunfaisal commented Sep 17, 2026

Uh oh!

openshift-ci Bot commented Sep 17, 2026

Uh oh!

asimurka commented Sep 18, 2026

Uh oh!

maysunfaisal commented Sep 18, 2026

Uh oh!

asimurka commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

maysunfaisal commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Tools used to create PR

Related Tickets & Documents

Checklist before requesting a review

Testing

Automated and build verification

OpenShift integration verification

Uh oh!

coderabbitai Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

maysunfaisal commented Sep 17, 2026

Uh oh!

red-hat-konflux-kflux-prd-rh02 Bot commented Sep 17, 2026

Uh oh!

maysunfaisal commented Sep 17, 2026

Uh oh!

openshift-ci Bot commented Sep 17, 2026

Uh oh!

asimurka commented Sep 18, 2026

Uh oh!

maysunfaisal commented Sep 18, 2026

Uh oh!

asimurka commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maysunfaisal commented Sep 17, 2026 •

edited

Loading

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading