Skip to content

LCORE-3518: Don't need to catch exception and silently pass them #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Sep 17, 2026
+2 −5
Merged

LCORE-3518: Don't need to catch exception and silently pass them #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/unit/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,8 @@ def _reset_app_config_between_tests() -> Generator:
AppConfig()._quota_limiters to an empty list, ignoring any exceptions, then
yields control to the test and repeats the cleanup after the test.
"""
try:
AppConfig()._configuration = None # type: ignore[attr-defined]
AppConfig()._quota_limiters = [] # type: ignore[attr-defined]
except Exception:
pass
AppConfig()._configuration = None # type: ignore[attr-defined]
AppConfig()._quota_limiters = [] # type: ignore[attr-defined]
yield
# ensure clean state after each test
try:
Expand Down
Loading