LCORE-2505: Add migration guide and deprecation notes for BYOK config refactoring#1882
LCORE-2505: Add migration guide and deprecation notes for BYOK config refactoring#1882are-ces wants to merge 1 commit into
Conversation
… refactoring Add docs/migrations/v0.7.0.md with field mapping, full RAG before/after examples, and chunk limit migration table. Add deprecation callouts to byok_guide.md and rag_guide.md linking to the migration guide. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis PR adds comprehensive v0.7.0 migration documentation for RAG configuration restructuring, consolidating four top-level configuration sections into a unified ChangesRAG Configuration Restructuring Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/migrations/v0.7.0.md`:
- Around line 11-27: The migration doc describes moving fields into rag.byok,
rag.okp and rag.retrieval.* but the runtime schema still exposes top-level
byok_rag, okp, reranker and rag.inline/rag.tool and code
(validate_reranker_auto_enable) reads self.reranker and self.rag.inline; update
the doc to match the actual v0.7.0 schema by changing the Field Mapping and
examples to show the current top-level paths (byok_rag, okp, reranker,
rag.inline/rag.tool) OR explicitly mark this migration as targeting a future
schema and add version gating guidance; also mention
validate_reranker_auto_enable, self.reranker, self.rag.inline and the top-level
config names so maintainers can reconcile examples with the runtime model.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 45cf17c1-0c9a-4824-ae83-763a7dddb35c
📒 Files selected for processing (3)
docs/byok_guide.mddocs/migrations/v0.7.0.mddocs/rag_guide.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: E2E Tests for Lightspeed Evaluation job
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: mypy
- GitHub Check: black
- GitHub Check: unit_tests (3.13)
- GitHub Check: unit_tests (3.12)
- GitHub Check: bandit
- GitHub Check: Pylinter
- GitHub Check: build-pr
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
🔇 Additional comments (2)
docs/byok_guide.md (1)
116-123: LGTM!docs/rag_guide.md (1)
66-73: LGTM!Also applies to: 323-328
Description
Adds a v0.7.0 migration guide and deprecation notices for the RAG configuration refactoring (PR #1843 / LCORE-1426). The migration guide documents the move from four separate top-level sections (
byok_rag,rag,okp,reranker) to a unified nestedragsection, including:Deprecation callouts are added to
byok_guide.mdandrag_guide.mdlinking to the migration guide.Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit