Skip to content

DO NOT MERGE: Use llamastack model identifier, not provider resource id, to refer to a model#6

Open
bparees wants to merge 1 commit into
lightspeed-core:mainfrom
bparees:modelid
Open

DO NOT MERGE: Use llamastack model identifier, not provider resource id, to refer to a model#6
bparees wants to merge 1 commit into
lightspeed-core:mainfrom
bparees:modelid

Conversation

@bparees

@bparees bparees commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@bparees bparees changed the title Use llamastack model identifier, not provider resource id, to refer to a model DO NOT MERGE: Use llamastack model identifier, not provider resource id, to refer to a model Aug 8, 2025
@bparees

bparees commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

this change needs to be coordinated with lightspeed-core/lightspeed-stack#368

@bparees

bparees commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

@eyevana i'm not sure what the merge process is for this repo, but we need to make sure this doesn't actually merge until we resolve some conversations and resolve/merge the changes in lightspeed-core/lightspeed-stack#368

@eyevana

eyevana commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

@bparees yes, I'm holding off until I get the green-light from you. @jrobertboos correct me if I'm wrong, but the merge process is pretty informal right? Do you communicate with anyone/team when fixes are applied in the main branch?

@bparees

bparees commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

github issue for the upstream llamastack behavior aspects of this:
ogx-ai/ogx#3116

@jrobertboos

Copy link
Copy Markdown
Collaborator

Hi @eyevana and @bparees, sorry for the delayed response I have been out backpacking since Saturday :). Yea the merge process for this repo is really informal, I don't really have to communicate with anyone about patches or fixes, for larger changes I will often times let the LCORE team take a look or demo the new feature/change.

@bparees

bparees commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

i've opened https://issues.redhat.com/browse/LCORE-600 to track resolving this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants