Skip to content

Add company legal name field to umaaas api#250

Closed
matthappens wants to merge 1 commit intomainfrom
mrdavis/add-company-legal-name-field
Closed

Add company legal name field to umaaas api#250
matthappens wants to merge 1 commit intomainfrom
mrdavis/add-company-legal-name-field

Conversation

@matthappens
Copy link
Copy Markdown

Thunes requires legalName from the sender when it's a business sender

{
    "code": "UNRECOGNIZED_MANDATORY_COUNTERPARTY_DATA_KEY",
    "reason": "Unrecognized counterparty field name companyLegalName"
}

this exists as UmaCounterpartyDataField.COMPANY_LEGAL_NAME, but how no corresponding CustomerInfoFieldName

@matthappens matthappens requested a review from shreyav April 18, 2026 22:48
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

Adds COMPANY_LEGAL_NAME to the UserInfoFieldName enum in both openapi.yaml and mintlify/openapi.yaml to support the Thunes requirement for a legal company name when the sender is a business. Both files are kept in sync with the same one-line addition.

Confidence Score: 5/5

Safe to merge — minimal, additive enum change with no breaking impact on existing consumers.

The change is a pure addition to an open string enum. Existing values and references are untouched, and both spec files are updated consistently.

No files require special attention.

Important Files Changed

Filename Overview
openapi.yaml Adds COMPANY_LEGAL_NAME to the UserInfoFieldName enum, enabling the field to be used in CounterpartyFieldDefinition and PlatformCurrencyConfig required-fields arrays.
mintlify/openapi.yaml Identical change to the Mintlify docs copy of the spec — COMPANY_LEGAL_NAME added to UserInfoFieldName enum to keep the two files in sync.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Business Sender] -->|requires companyLegalName| B[Thunes Provider]
    B -->|maps to| C[UmaCounterpartyDataField.COMPANY_LEGAL_NAME]
    C -->|previously missing| D[UserInfoFieldName enum]
    D -->|now includes| E[COMPANY_LEGAL_NAME ✅]
    E --> F[CounterpartyFieldDefinition]
    E --> G[PlatformCurrencyConfig\nrequiredUserFields / requiredCounterpartyFields]
Loading

Reviews (1): Last reviewed commit: "Add company legal name field to umaaas a..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@shreyav shreyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in grid-api?

Copy link
Copy Markdown
Author

@shreyav I'm not sure? is that where CustomerInfoFieldNames normally live? my instructions say Id need to update grid-api with this version of umaaas-api

Copy link
Copy Markdown
Contributor

shreyav commented Apr 18, 2026

yeah CustomerInfoFieldName is in grid-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants