Add company legal name field to umaaas api#250
Conversation
Greptile SummaryAdds Confidence Score: 5/5Safe to merge — minimal, additive enum change with no breaking impact on existing consumers. The change is a pure addition to an open string enum. Existing values and references are untouched, and both spec files are updated consistently. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi.yaml | Adds COMPANY_LEGAL_NAME to the UserInfoFieldName enum, enabling the field to be used in CounterpartyFieldDefinition and PlatformCurrencyConfig required-fields arrays. |
| mintlify/openapi.yaml | Identical change to the Mintlify docs copy of the spec — COMPANY_LEGAL_NAME added to UserInfoFieldName enum to keep the two files in sync. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Business Sender] -->|requires companyLegalName| B[Thunes Provider]
B -->|maps to| C[UmaCounterpartyDataField.COMPANY_LEGAL_NAME]
C -->|previously missing| D[UserInfoFieldName enum]
D -->|now includes| E[COMPANY_LEGAL_NAME ✅]
E --> F[CounterpartyFieldDefinition]
E --> G[PlatformCurrencyConfig\nrequiredUserFields / requiredCounterpartyFields]
Reviews (1): Last reviewed commit: "Add company legal name field to umaaas a..." | Re-trigger Greptile
shreyav
left a comment
There was a problem hiding this comment.
should this be in grid-api?
|
@shreyav I'm not sure? is that where CustomerInfoFieldNames normally live? my instructions say Id need to update grid-api with this version of umaaas-api |
|
yeah CustomerInfoFieldName is in grid-api |
Thunes requires legalName from the sender when it's a business sender
this exists as UmaCounterpartyDataField.COMPANY_LEGAL_NAME, but how no corresponding CustomerInfoFieldName