Skip to content

feat: add bankAddress to USD funding payment instructions - #840

Merged
wuvictor-95 merged 1 commit into
mainfrom
grid-usd-funding-bank-address
Aug 17, 2026
Merged

feat: add bankAddress to USD funding payment instructions#840
wuvictor-95 merged 1 commit into
mainfrom
grid-usd-funding-bank-address

Conversation

@wuvictor-95

@wuvictor-95 wuvictor-95 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What this does

USD funding payment instructions tell someone how to send money into a Grid internal account. They carry an account number, a routing number, and the bank's name.

They do not carry the bank's address. Many originating banks will not send a wire until they have the beneficiary institution's postal address, so a platform has to look it up somewhere else and paste it in by hand.

This PR adds an optional bankAddress field to PaymentUsdAccountInfo.

How it works

bankAddress is a single-line string, up to 255 characters. It is optional on every rail. It matters most on wires, where the originating bank asks for it.

The field is additive. Nothing that reads USD funding instructions today has to change.

Where the field sits

It went on PaymentUsdAccountInfo rather than on the shared UsdAccountInfoBase.

The base is also composed into USD external accounts. Those have no place to store a bank address, so adding it there would have advertised an input that the API accepts and then silently drops.

What else changed

The bundled openapi.yaml and mintlify/openapi.yaml were rebuilt with make build, so the API reference picks the field up. make lint passes.

The two USD funding examples in the internal accounts docs snippet now show bankAddress alongside bankName.

Related

The backend that fills this field in is lightsparkdev/webdev#32807.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Aug 17, 2026 5:23pm
grid-wallet-demo Ignored Ignored Preview Aug 17, 2026 5:23pm

Request Review

@mintlify

mintlify Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Aug 17, 2026, 5:03 PM

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

go

feat(api): add bank_address parameter to USD external account creation

kotlin

feat(api): add bankAddress to UsdExternalAccountCreateInfo and UsdAccountInfo

openapi

feat(api): add bankAddress field to USD account info

php

feat(api): add bankAddress field to USD account models

python

feat(api): add bank_address field to usd_external_account_create_info

ruby

feat(api): add bank_address field to UsdAccountInfo/UsdExternalAccountCreateInfo

typescript

feat(api): add bankAddress field to USD external account creation
⚠️ grid-openapi studio · code

Your SDK build had at least one "warning" diagnostic.
generate ⚠️

grid-ruby studio · code

generate ✅build ⏭️lint ⏳test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ⏭️lint ❗test ❗

go get github.com/stainless-sdks/grid-go@95c1e09b2a3ff44180a33eaa036064e1bc431140
grid-kotlin studio · code

generate ⚠️build ⏭️lint ⏭️test ⏳

grid-typescript studio · conflict

Your SDK build had at least one note diagnostic.

⚠️ grid-python studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ✅build ⏭️lint ⏭️test ❗

grid-php studio · code

generate ✅lint ⏳test ✅

grid-cli studio · code

generate ⚠️build ⏭️lint ⏭️test ⏳

⏳ These are partial results; builds are still running.


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-08-17 17:48:54 UTC

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

ฅ^•ﻌ•^ฅ This PR adds an optional, length-bounded bankAddress field to USD account information so clients can provide beneficiary-bank postal details when needed. ʕ•ᴥ•ʔ

  • Adds bankAddress to the canonical USD account-info schema.
  • Regenerates both bundled OpenAPI specifications.
  • Updates two internal-account funding examples with a realistic bank address. (づ。◕‿‿◕。)づ

Confidence Score: 5/5

The PR appears safe to merge, with the source schema, generated bundles, and documentation examples consistently updated.

The new field is additive and optional, has appropriate validation bounds, and is represented consistently across the canonical schema and generated documentation artifacts.

Important Files Changed

Filename Overview
openapi/components/schemas/common/UsdAccountInfoBase.yaml Adds the optional bankAddress property with clear documentation and string-length constraints to the canonical shared USD schema.
openapi.yaml Correctly reflects the source-schema addition in the committed generated OpenAPI bundle.
mintlify/openapi.yaml Remains synchronized with the root generated OpenAPI bundle.
mintlify/snippets/internal-accounts.mdx Adds syntactically valid and realistic bankAddress values to both USD funding examples.

Reviews (1): Last reviewed commit: "feat: add bankAddress to USD account inf..." | Re-trigger Greptile

Wire senders often need the beneficiary bank's postal address, so add an
optional bankAddress field to PaymentUsdAccountInfo.

It sits on the payment shape rather than the shared UsdAccountInfoBase so it
does not appear as an accepted-then-ignored input on USD external accounts.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@wuvictor-95
wuvictor-95 force-pushed the grid-usd-funding-bank-address branch from 75fe165 to 2bd2e90 Compare August 17, 2026 17:23
@wuvictor-95 wuvictor-95 changed the title feat: add bankAddress to USD account info feat: add bankAddress to USD funding payment instructions Aug 17, 2026
@wuvictor-95
wuvictor-95 enabled auto-merge (squash) August 17, 2026 17:45
@wuvictor-95
wuvictor-95 merged commit 75123c7 into main Aug 17, 2026
7 of 8 checks passed
@wuvictor-95
wuvictor-95 deleted the grid-usd-funding-bank-address branch August 17, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants