Skip to content

dev.Dockerfile: use cache mounts to speed up rebuilding #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dev.Dockerfile: use cache mounts to speed up rebuilding #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dev.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,13 @@ ARG NO_UI
ARG CGO_ENABLED=1

# Install dependencies and install/build lightning-terminal.
RUN apk add --no-cache --update alpine-sdk make \
# Note: When using `docker build`, setting the environmental variable
# `DOCKER_BUILDKIT=1` is required to enable
# [BuildKit](https://docs.docker.com/build/buildkit)
# so that the cache mounts can be used.
RUN --mount=type=cache,target=/go/pkg/mod \
--mount=type=cache,target=/root/.cache/go-build \
apk add --no-cache --update alpine-sdk make \
&& cd /go/src/github.com/lightninglabs/lightning-terminal \
# If a custom lnd version is supplied, force it now.
&& if [ -n "$LND_VERSION" ]; then \
Expand Down
12 changes: 12 additions & 0 deletions docs/release-notes/release-notes-0.16.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@

### Functional Changes/Additions

* `dev.Dockerfile` now uses
[cache mounts](https://docs.docker.com/build/cache/optimize/#use-cache-mounts)
to cache the `GOMODCACHE` and `GOCACHE` directories so that dependencies don't
need to be re-downloaded and re-built every time the image is re-created.
As a result of this change, `dev.Dockerfile` now requires
[BuildKit](https://docs.docker.com/build/buildkit) to build. When using
`docker build`, this can be enabled by setting the environmental variable
`DOCKER_BUILDKIT=1`. BuildKit also does not unnecessarily rebuild images when
the build context is a remote git repository because COPY layers are more
smartly compared to cache.


### Technical and Architectural Updates

## RPC Updates
Expand Down
Loading