Replace bb8 with SmallPool, a simple round-robin
#86
+78
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Contributor
Author
|
This could get smarter yes, I am wondering if we can at least ship something like this to see if it fixes the OOM ? |
TheBlueMatt
reviewed
Jan 21, 2026
Contributor
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Makes sense to me. Less total code makes me feel all warm and fuzzy.
rust/impls/src/postgres_store.rs
Outdated
|
|
||
| struct SmallPool<T> { | ||
| connections: [Mutex<Client>; 10], | ||
| index: AtomicU64, |
Contributor
There was a problem hiding this comment.
Why bother with an index? Why not just every time we need to make a query, select an attempt to lock all ten and use whichever locks first.
tankyleo
force-pushed
the
26-01-drop-bb8
branch
from
f7f9252 to
7ad5a27
Compare
tankyleo
force-pushed
the
26-01-drop-bb8
branch
from
7ad5a27 to
b96325a
Compare
TheBlueMatt
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.