Skip to content

Make test_sig more robust #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tankyleo merged 1 commit into from
Jan 20, 2026
Merged

Make test_sig more robust #84

tankyleo merged 1 commit into from
Jan 20, 2026

Conversation

@TheBlueMatt
Copy link
Contributor

@TheBlueMatt TheBlueMatt commented Jan 20, 2026 •
edited
Loading

test_sig fails if the signature already contained a zero byte, at
the overwritten position, due to a hex <-> bytes conversion issue.

Fixes #83

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 20, 2026 •
edited
Loading

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull
tnull reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a test fixture for such a case that would fail before and now passes?

@TheBlueMatt
Copy link
Contributor Author

TheBlueMatt commented Jan 20, 2026

Not quite sure what you're asking for? You want me to refactor the test to take a private key so that we can add a test of the test?

@tnull
Copy link
Contributor

tnull commented Jan 20, 2026

Not quite sure what you're asking for? You want me to refactor the test to take a private key so that we can add a test of the test?

Lol, nevermind, I misunderstood what was happening here.

tankyleo
tankyleo approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_sig fails if the signature already contained two zero bytes, which is apparently less rare than we thought.

We were previously overwriting just a single byte, but good to go thank you

@TheBlueMatt
Make test_sig more robust
9a88343 
`test_sig` fails if the signature already contained a zero byte, at
the overwritten position, due to a hex <-> bytes conversion issue.

Fixes lightningdevkit#83
tankyleo
tankyleo approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@tankyleo tankyleo merged commit 803d8c5 into lightningdevkit:main Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull left review comments

@tankyleo tankyleo tankyleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

signature::tests::test_sig is unstable

4 participants

@TheBlueMatt @ldk-reviews-bot @tnull @tankyleo