Skip to content

Conversation

@carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Dec 1, 2025

Addressing followups:

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 1, 2025

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.32%. Comparing base (3e186bc) to head (2a53ffd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/onion_payment.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4252   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         180      180           
  Lines      138966   138966           
  Branches   138966   138966           
=======================================
+ Hits       124121   124126    +5     
+ Misses      12218    12216    -2     
+ Partials     2627     2624    -3     
Flag Coverage Δ
fuzzing 35.98% <0.00%> (+<0.01%) ⬆️
tests 88.68% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valentinewallace valentinewallace merged commit 8906d0c into lightningdevkit:main Dec 1, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants