Skip to content

Replace rcgen with custom X.509 certificate generation #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benthecarman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace rcgen with custom X.509 certificate generation #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6aea69
Replace rcgen with custom X.509 certificate generation
benthecarman Jan 20, 2026
31e8feb
Switch use of rand with getrandom
benthecarman Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ldk-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ http-body-util = { version = "0.1", default-features = false }
hyper-util = { version = "0.1", default-features = false, features = ["server-graceful"] }
tokio = { version = "1.38.0", default-features = false, features = ["time", "signal", "rt-multi-thread"] }
tokio-rustls = { version = "0.26", default-features = false, features = ["ring"] }
rcgen = { version = "0.13", default-features = false, features = ["ring"] }
ring = { version = "0.17", default-features = false }
Copy link

@TheBlueMatt TheBlueMatt Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we're gonna ship a binary, I do very much wonder whether we shouldn't use native-tls across the stack in ldk-server. That would avoid us being responsible for shipping updates to ring and rustls in case of a security issue (though honestly I'm not entirely clear on why we want TLS for the RPC to begin with)

Copy link

@TheBlueMatt TheBlueMatt Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if we did so we could retain the cert-building logic here by switching to secp256k1 rather than secp256r1-via-ring.

getrandom = { version = "0.2", default-features = false }
prost = { version = "0.11.6", default-features = false, features = ["std"] }
ldk-server-protos = { path = "../ldk-server-protos" }
bytes = { version = "1.4.0", default-features = false }
hex = { package = "hex-conservative", version = "0.2.1", default-features = false }
rusqlite = { version = "0.31.0", features = ["bundled"] }
rand = { version = "0.8.5", default-features = false }
async-trait = { version = "0.1.85", default-features = false }
toml = { version = "0.8.9", default-features = false, features = ["parse"] }
chrono = { version = "0.4", default-features = false, features = ["clock"] }
Expand Down
8 changes: 4 additions & 4 deletions ldk-server/src/io/persist/sqlite_store/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,8 @@ impl PaginatedKVStore for SqliteStore {
mod tests {
use std::panic::RefUnwindSafe;

use hex::DisplayHex;
use ldk_node::lightning::util::persist::KVSTORE_NAMESPACE_KEY_MAX_LEN;
use rand::distributions::Alphanumeric;
use rand::{thread_rng, Rng};

use super::*;

Expand All @@ -312,8 +311,9 @@ mod tests {

pub(crate) fn random_storage_path() -> PathBuf {
let mut temp_path = std::env::temp_dir();
let mut rng = thread_rng();
let rand_dir: String = (0..7).map(|_| rng.sample(Alphanumeric) as char).collect();
let mut bytes = [0u8; 8];
getrandom::getrandom(&mut bytes).expect("Failed to generate random bytes");
let rand_dir = bytes.to_lower_hex_string();
temp_path.push(rand_dir);
temp_path
}
Expand Down
8 changes: 3 additions & 5 deletions ldk-server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ use ldk_server_protos::events::{event_envelope, EventEnvelope};
use ldk_server_protos::types::Payment;
use log::{debug, error, info};
use prost::Message;
use rand::Rng;
use tokio::net::TcpListener;
use tokio::select;
use tokio::signal::unix::SignalKind;
Expand Down Expand Up @@ -408,8 +407,8 @@ fn main() {
// We don't expose this payment-id to the user, it is a temporary measure to generate
// some unique identifiers until we have forwarded-payment-id available in ldk.
// Currently, this is the expected user handling behaviour for forwarded payments.
let mut forwarded_payment_id = [0u8;32];
rand::thread_rng().fill(&mut forwarded_payment_id);
let mut forwarded_payment_id = [0u8; 32];
getrandom::getrandom(&mut forwarded_payment_id).expect("Failed to generate random bytes");

let forwarded_payment_creation_time = SystemTime::now().duration_since(UNIX_EPOCH).expect("Time must be > 1970").as_secs() as i64;

Expand Down Expand Up @@ -546,9 +545,8 @@ fn load_or_generate_api_key(storage_dir: &Path) -> std::io::Result<String> {
Ok(key_bytes.to_lower_hex_string())
} else {
// Generate a 32-byte random API key
let mut rng = rand::thread_rng();
let mut key_bytes = [0u8; 32];
rng.fill(&mut key_bytes);
getrandom::getrandom(&mut key_bytes).map_err(std::io::Error::other)?;

// Write the raw bytes to the file
fs::write(&api_key_path, key_bytes)?;
Expand Down
Loading