tests: Add interoperability tests for BOLT12 (Offers) with CLN#905
Open
alexgrad42 wants to merge 1 commit into
Open
Conversation
|
I've assigned @tnull as a reviewer! |
alexgrad42
force-pushed
the
feature/add_bolt12_scenario_coverage_to_interop_tests
branch
from
d032015 to
bf29202
Compare
Activates scenarios for BOLT12 offer payments between ldk-node and Core Lightning (CLN) inside integration tests Fix lightningdevkit#856
alexgrad42
force-pushed
the
feature/add_bolt12_scenario_coverage_to_interop_tests
branch
from
bf29202 to
bd238f7
Compare
tnull
reviewed
May 18, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Some comments.
|
|
||
| /// Blocks execution until the channel with the specified peer becomes active (`is_usable == true`). | ||
| /// Maximum wait time is 15 seconds (30 attempts with a 500ms interval). | ||
| pub(crate) async fn wait_for_channel_usable(node: &Node, counterparty_node_id: PublicKey) { |
Collaborator
There was a problem hiding this comment.
We shouldn't use this manual sleep, we have events for that.
|
|
||
| /// Specialized version of `force_close_after_payment_scenario` for BOLT11 payments. | ||
| /// See [`force_close_after_payment_scenario`] for details. | ||
| pub(crate) async fn force_close_after_payment_bolt11_scenario<E: ElectrumApi>( |
Collaborator
There was a problem hiding this comment.
I don't understand why we need all this additional boilerplate.
| payment::send_bolt11_to_peer(node, peer, 5_000_000, "post-splice-bolt11").await; | ||
| }, | ||
| PaymentProtocol::Bolt12 => { | ||
| // Wait for Onion Message router updates the channel to usable state. |
Collaborator
There was a problem hiding this comment.
I don't think I understand what "Wait for Onion Message router updates the channel to usable state." means. Can you expand?
|
|
||
| /// Specialized version of `splice_in_scenario` for BOLT11 payments. | ||
| /// See [`splice_in_scenario`] for details. | ||
| pub(crate) async fn splice_in_bolt11_scenario<E: ElectrumApi>( |
Collaborator
There was a problem hiding this comment.
Please avoid adding helper methods that are less than 5 lines of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activates scenarios for BOLT12 offer payments between ldk-node and Core Lightning (CLN) inside integration tests
Fix #856