Skip to content

fix(windows): hide npm launcher proxy child - #1268

Closed
Ingwannu wants to merge 1 commit into
devfrom
agent/fix-1236-windows-launcher-hide
Closed

fix(windows): hide npm launcher proxy child#1268
Ingwannu wants to merge 1 commit into
devfrom
agent/fix-1236-windows-launcher-hide

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Set windowsHide: true on the final Node-to-Bun npm launcher spawn.
  • Prevent headless Windows starts and restarts from allocating a visible, closable console for the long-running proxy child.
  • Add a source-scoped regression for the exact Bun child spawn boundary.

Closes #1236

Verification

  • taskset -c 0-1 bun test tests/ocx-launcher-source.test.ts tests/ocx-launcher-runtime.test.ts tests/shutdown-launcher.test.ts — 13 passed and 2 platform skips.
  • taskset -c 0-1 bun run typecheck — passed.
  • taskset -c 0-1 bun run privacy:scan — passed.
  • The launcher integration checks cover signal forwarding, proxy teardown, and Codex config restoration after the spawn-option change.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Bug Fixes
    • Prevented an unnecessary console window from appearing when launching the application headlessly on Windows.
    • Preserved standard input, output, and error stream behavior for the long-running process.
  • Tests
    • Added coverage to verify the Windows launch behavior and inherited console streams.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The npm launcher now sets windowsHide: true when it spawns Bun. A source-level test verifies that the final spawn preserves inherited stdio and enables Windows console suppression.

Changes

Windows launcher behavior

Layer / File(s) Summary
Configure and validate hidden Bun spawning
bin/ocx.mjs, tests/ocx-launcher-source.test.ts
The Bun child spawn now sets windowsHide: true while retaining inherited stdio. The source-level test verifies both spawn options.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: lidge-jun, wibias

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes implement issue #1236 by adding windowsHide: true to the Bun spawn and adding a regression test for the required behavior.
Out of Scope Changes check ✅ Passed The changes are limited to the npm launcher and its regression test, with no unrelated code or scope expansion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the Windows fix to hide the npm launcher proxy child, matching the main change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-1236-windows-launcher-hide

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@lidge-jun

Copy link
Copy Markdown
Owner

Landed on dev as dd02029, rebased onto the current head with your authorship preserved.

Independent security review passed clean: the child handle is still retained, signal forwarding and exit/error handling are unchanged, and stdio stays inherited — windowsHide only suppresses the console allocation. Full suite green on the rebased head (10189 pass, 0 fail).

Thanks — the test distinguishing this long-running spawn from the helper spawns is what made the scope obvious.

@lidge-jun lidge-jun closed this Aug 9, 2026
@Wibias
Wibias deleted the agent/fix-1236-windows-launcher-hide branch August 9, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants