fix(windows): hide npm launcher proxy child - #1268
Conversation
📝 WalkthroughWalkthroughThe npm launcher now sets ChangesWindows launcher behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Landed on Independent security review passed clean: the child handle is still retained, signal forwarding and exit/error handling are unchanged, and stdio stays inherited — Thanks — the test distinguishing this long-running spawn from the helper spawns is what made the scope obvious. |
Summary
windowsHide: trueon the final Node-to-Bun npm launcher spawn.Closes #1236
Verification
taskset -c 0-1 bun test tests/ocx-launcher-source.test.ts tests/ocx-launcher-runtime.test.ts tests/shutdown-launcher.test.ts— 13 passed and 2 platform skips.taskset -c 0-1 bun run typecheck— passed.taskset -c 0-1 bun run privacy:scan— passed.Checklist
Summary by CodeRabbit