fix(deepseek): restore progressive Responses streaming - #1095
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review readiness checklistThis PR is kept in draft until every requirement below is fulfilled. The tickable checklist has been added to your PR description — tick all four boxes there.
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
✅ Deterministic PR hygiene checks passed. |
|
Reviewed as part of a sweep of the The bug is real: What makes the fix defensible rather than merely effective is that it does not simply trust the stream. It removes the forced-JSON setting for that one model, wraps only its SSE path before the inspection/client split, and synthesizes The terminal-repair tests are genuine — fragmentation, timer races, malformed calls, cancellation, budget exhaustion, plus HTTP and WebSocket integration. Each would fail without the wrapper. Your remaining blocker is mechanical, not technical. The PR is still a draft and the head is 341 commits behind Two files you are touching have moved since your base, so please rebase rather than merging Nothing else from me. Once it is rebased and out of draft this is ready for a maintainer. |
Summary
deepseek-v4-flashon the Responses passthrough path so Codex receives reasoning, text, and tool-call progress incrementally instead of waiting for one bounded JSON body.response.completedafter every opened output item has a structurally completeoutput_item.done; partial, malformed, duplicate, contradictory, or unknown lifecycles fail closed withresponse.incomplete.This branch is based on
devcommit18b46cf5478c9f682d28503d0636e169fbbad9ed.Verification
bun run typecheck— passed.bun run privacy:scan— passed.bun run test— 8,475 passed, 8 skipped, 0 failed across 8,483 tests in 543 files.ASTRO_TELEMETRY_DISABLED=1 bun run buildindocs-site/— 216 pages built successfully.handleResponsespath — HTTP 200, first output in about 0.7 seconds, reasoning and function-call events observed, and exactly oneresponse.completedterminal.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I fixed all correct Codex and CodeRabbit findings.
My PR is ready for review.