Repository navigation
Conversation
crazy-max
left a comment
There was a problem hiding this comment.
Looking at this service I think we should have a new env var named smth like LIBRENMS_IRC_SERVICE instead of relying on irc_alert config.
|
Seems like the bot is unable to send alerts. Possibly because the alerts are triggered by the dispatcher container, which does not have access to the .ircbot.alert file. |
|
This PR needs to be merged to make alerting work in the container based environment. |
Moving to draft while waiting for the upstream PR to be merged |
|
Approved upstream, will be in 23.5 |
|
Now that 23.5 has been released. This should be ready. |
This will ensure that the irc-bot is started if irc_alert is configured.
- Changed startup to depend on nevironment variable - Fixed uid/gid - Shortened final sleep before restart (not sure about this one)
The run script started irc.php as a child of the shell, so s6-svc -r only signalled the shell: the old bot kept running and a second one was started next to it, both reading the same alert queue. exec the bot, and wait before starting instead of after it exits, so a bot that cannot connect still retries only every 10 seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I've pushed a small follow-up to the run script. The bot was started as a child of the shell, so I've been running this in my own build without problems. |
This will ensure that the irc-bot is started if the enviroment-variable LIBRENMS_IRC_SERVICE is set to "1".
You still need to enable irc_alert in the config to use the ircbot for alerting.