feat(lfs): add FastCDC media transport - #461
Merged
Merged
Conversation
marshawcoco
marked this pull request as ready for review
August 30, 2026 14:45
Signed-off-by: Henry Guo <marshawcoco@gmail.com>
Signed-off-by: Henry Guo <marshawcoco@gmail.com>
genedna
force-pushed
the
feat/lfs-fastcdc
branch
from
August 31, 2026 23:00
5d0becc to
2f790f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastcdc-v1chunker, manifest, and local chunk store to normal LFS push/download flowsThis is the client half of a coordinated Mega server change. Mega companion PR: gitmono-dev/mega#2178
Verification
cargo test --features fastcdc --test compat_fastcdc_feature_gate_guard: 2 passedcargo test --features fastcdc --test media_fastcdc_test: 6 passed, 1 interop case ignoredcargo test --features fastcdc --lib utils::media::: 12 passedcargo +nightly fmt --all --check,git diff --check, and a Playwright 1.62.1 Chromium install dry-run passed after repairing the self-hosted Web E2E workflowThe PR also removes Playwright's per-job
--with-depsinvocation from the self-hosted Web E2E job. The runner must provide its Linux browser dependencies; the old command attempted interactivesudoand had timed out for five minutes across multiple unrelated PRs before any E2E test ran.cargo test --features fastcdc --libcompleted with 4,196 passed and 98 failures in non-FastCDC Windows-sensitive areas. Those failures were not individually proven to be baseline failures because the clean-baseline comparison was itself blocked by unguarded Unix-only test code. The two--allruns and strict all-targets/all-features Clippy were also non-zero on Windows. This PR does not claim full CI is green.Deployment boundary
The feature is disabled by default and can be disabled per repository with
lfs.fastcdc=false. The HTTP fixture uses loopback, an injected test client/token, SQLite, and Local object storage. It does not validate production credential storage, a complete Mono deployment, S3/GCS backends, shared repository ACLs, quotas, or garbage collection.CI follow-up — 2026-08-31
Follow-up head:
5d0becc4ad06db957654a61182fe83cd75b8c9f2(signed and pushed). The earlier verification results above are historical; they are not a fresh full-suite or HTTP interop result for this head.9a0530b77failedcompat-offline-core(9,182 passed, 22 failed). Local fixes address 16 failures: restore host-only HTTP remotes' root LFS endpoints, repair the five-column media grading row, and register the interop test's cwd serial lane. Local checks passed: existing sub-face tests 4/4, extracted production URL functions and existing tests 3/3, serial annotation guard 1/1, and fmt/diff checks. The real CLI lock tests still need a newly built binary and remote rerun; the exact serial registry guard remains affected by Windows path separators locally.Fresh
cargo check --features fastcdc --lib --test media_fastcdc_test --test compat_fastcdc_feature_gate_guard -j 1passed on Windows (24 warnings retained). This is not a test execution or strict Clippy result.As of 2026-08-31 10:35 +08, the new head has 1 successful, 1 neutral, 2 failed, 4 running and 4 queued checks. rustfmt job 99363858524 failed downloading nightly metadata with
tls handshake eof; the formatter itself was skipped. A normal job rerun request returned HTTP 403 (Must have admin rights to Repository), so a maintainer must rerun it. RISC-V job 99363858175 again failed installing Web dependencies: pnpm 11.10.0 reported tarball extraction errors and an invalid numericsrcargument importing@noble/ciphers; Rust build was skipped. The runner/package-manager environment needs investigation. Other checks have not finished. The production and cloud-storage validation boundaries above are unchanged.Final merge update — 2026-09-01
Merged into
mainas1a590b6af1c755f847717db4477fc2153964f8bf. Before merge, maintainers rebased the branch ontodad35f23and rewrote the final PR head to2f790f7f25f54655f187c04ba898f8378940f810; the FastCDC implementation and tests were preserved.compat-offline-core: 9,257 passed, 3 skipped; all 13 prior LFS lock regressions and both FastCDC feature-gate tests passedThe companion Mega PR #2178 is also merged.