Fix emulator corr indexing#657
Open
dmcdougall wants to merge 6 commits intolibqueso:v0.58.0-releasefrom
Open
Conversation
We were assuming only one basis vector when indexing the emulator correlation strength.
This relied on the correct calculation of how many emulator correlation strength parameters there were; we had assumed there was one svd term.
Again, this relied on the calculation of the number of emulator correlation strength parameters. We had assumed there was one svd basis vector which is an incorrect assumption.
There are num_svd_terms of these things, not 1.
We were underestimating how many of these variables there were. There aren't always dimScenario+dimParameter. There's dimScenario+dimParameter *for each* emulator precision variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roystgnr this is what I've been working on. Super not ready to merge yet.