context: skip shutdown eventfd without REST endpoint - #112
Draft
jasonthird wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Iason Malkotsis <imalkotsis@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates KrunContext::run() to only request libkrun’s shutdown eventfd when a REST status/shutdown listener is actually configured, avoiding an un-signalable shutdown fd and preventing an unnecessary shutdown device from being exposed to guests when --restful-uri none:// is used.
Changes:
- Gate creation of the libkrun shutdown eventfd behind the presence of a TCP or Unix REST endpoint.
- Keep existing listener-thread behavior for TCP/Unix REST endpoints while skipping it for
none://(and unset) configurations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Only spawn a listener thread if the user specified unix:// or tcp:// | ||
| // Only create a shutdown eventfd and listener for unix:// or tcp:// endpoints. | ||
| if uri.as_ref().is_some_and(|u| *u != RestfulUri::None) { |
tylerfanelli
marked this pull request as draft
July 29, 2026 04:19
Collaborator
|
Marked this as draft until libkrun/libkrun#802 is merged in order to effectively gate this behind that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only request libkrun's shutdown eventfd when krunkit is configured with a TCP or Unix REST endpoint.
When
--restful-uri none://is used, no status listener exists and the shutdown eventfd cannot be signalled. Avoiding the request also prevents libkrun from exposing an unused GPIO shutdown device to the guest.TCP and Unix REST endpoints retain their existing orderly-shutdown behavior.
Depends on: libkrun/libkrun#802
Testing
cargo test --locked— 36 tests passedcargo clippy --locked -- -D warnings/dev/input/event0or GPIO platform devicesystemd-logindremained at 0.0% CPU