Skip to content

WIP: Rebase Refactoring#1510

Open
ethomson wants to merge 4 commits intomasterfrom
ethomson/rebase
Open

WIP: Rebase Refactoring#1510
ethomson wants to merge 4 commits intomasterfrom
ethomson/rebase

Conversation

@ethomson
Copy link
Copy Markdown
Member

Goals:

  1. Move Rebase into the commands that we've started.
  2. Provide the ability to do in-memory / bare rebases.

Xunit 2.3 now considers it an error to pass a integer type when a
enum was expected.
Introduce a Rebase class that maps to the rebase object in libgit2 more
directly.
@benkoshy
Copy link
Copy Markdown

benkoshy commented Dec 2, 2017

Hi there
first of all thank you for your contribution to the code base

I would like to know re: this refactoring - what is the reason/purpose for it?

rgds

Ben

@ethomson
Copy link
Copy Markdown
Member Author

ethomson commented Dec 2, 2017

Ideally users would be able to do a rebase completely in memory, without touching the working directory, and with custom ODB, etc backends. This is well supported by libgit2 but LibGit2Sharp makes various assumptions and these configurations are difficult or impossible.

@benkoshy
Copy link
Copy Markdown

benkoshy commented Dec 5, 2017

ok chrs. appreciate the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants