Bugfix: Update tests for current GEOS versions#3
Open
ejn wants to merge 13 commits intolibgeos:masterfrom
Open
Bugfix: Update tests for current GEOS versions#3ejn wants to merge 13 commits intolibgeos:masterfrom
ejn wants to merge 13 commits intolibgeos:masterfrom
Conversation
added 13 commits
November 29, 2023 13:23
WKB Multipoint formatting update, see libgeos/geos#903
2, 3, or 4 dimensions. Default since GEOS 3.12 is 4. see: libgeos/geos#908
Set trim to true to go with all GEOS Versions, mentioned here https://git.osgeo.org/gitea/geos/php-geos/issues/31
Also see libgeos/geos#903 Convert to consistent format before comparison, see: libgeos/geos@4acb5e0
defines several constants related to the GEOS library version
also deleting unnecessary lines/comments
Introduce `assertEqualsAny` function for cleaner assertions with more than two expected values. Correct the version comparison for GEOS_DEFAULT_EMPTY from 3.11 to 3.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://git.osgeo.org/gitea/geos/php-geos/issues/23 and https://git.osgeo.org/gitea/geos/php-geos/issues/31 various failed tests are mentioned, together with the comment "we have to decide whether to just expect the new behaviour or check GEOS version at testruntime to expect different outputs".
Our approach is to try and support a reasonable range of GEOS versions in a reasonably straightforward way whilst making only minimal changes in the tests.
This branch has been checked to pass all tests using all Debian versions from Buster (GEOS 3.7.1) through to Trixie (GEOS 3.12.1), which seems to us to be a reasonable target range.