Skip to content

Feature/windows build#2

Open
eisberg wants to merge 13 commits intolibgeos:masterfrom
ModelTech:feature/windows-build
Open

Feature/windows build#2
eisberg wants to merge 13 commits intolibgeos:masterfrom
ModelTech:feature/windows-build

Conversation

@eisberg
Copy link

@eisberg eisberg commented Nov 2, 2020

Added Window Build

See new release in fork: https://github.com/ModelTech/php-geos/releases/tag/1.0.1

strk
strk reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

CREDITS
Sandro Santilli <strk@kbt.io> - GEOS
J Smith <dark.panda@gmail.com> <jay@php.net> - PHP packaging
Sandro Santilli strk@kbt.io - GEOS
J Smith dark.panda@gmail.com jay@php.net - PHP packaging
Copy link
Member

@strk strk Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this format change ?

Copy link
Author

@eisberg eisberg Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of < > The RC resource compiler crashes

Copy link
Member

@strk strk Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like an upstream bug. The current one does not crash, right ?

Copy link
Author

@eisberg eisberg Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the current version compiles without errors

strk
strk requested changes Nov 16, 2020
View reviewed changes
CREDITS
Sandro Santilli <strk@kbt.io> - GEOS
J Smith <dark.panda@gmail.com> <jay@php.net> - PHP packaging
Sandro Santilli strk@kbt.io - GEOS
J Smith dark.panda@gmail.com jay@php.net - PHP packaging
Copy link
Member

@strk strk Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like an upstream bug. The current one does not crash, right ?

@nono303
Copy link

nono303 commented Nov 30, 2020

Many thanks @eisberg!
here my full patch for PHP8 based on your PR2
php-geos.zip

@nono303
Copy link

nono303 commented Jan 17, 2021

Hi,
Just updated config.w32 in my ModelTech@9df7f32 to have full functionality of libgeos

@javabudd
Copy link

javabudd commented Jun 21, 2021

Can we decouple the PHP8 functionality from this PR and introduce it as its own?

@nono303
Copy link

nono303 commented Feb 11, 2024 •
edited
Loading

Hi,
Here is a patch of the PR decoupled from PHP8 functionality php_geos-win.diff
(diff from https://github.com/nono303/php-geos)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strk strk strk requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eisberg @nono303 @javabudd @strk @faytekin