fix null-deref warning in tokenize_on_space, promote strict-warnings to required#359
Open
abhinavagarwal07 wants to merge 1 commit into
Open
fix null-deref warning in tokenize_on_space, promote strict-warnings to required#359abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
| if (str) | ||
| pos = str; | ||
|
|
||
| if (!pos) |
Collaborator
Author
There was a problem hiding this comment.
pos null check is done here already
Collaborator
Author
abhinavagarwal07
force-pushed
the
fix-null-deref-strict-warnings
branch
from
6bd45be to
c71eea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant NULL guard in
tokenize_on_space()that confused gcc's null-dereference analysis.posis guaranteed non-NULL at that point (checked on line 3948, andpos++cannot produce NULL).With the warning fixed, remove
continue-on-error: truefrom the strict-warnings CI job so both gcc and clang strict-warning builds are now required.Stacked on #353.