fix: gate compat mixins on mixin class name, not target class name - #23
Open
Febreeze-sys wants to merge 1 commit into
Open
fix: gate compat mixins on mixin class name, not target class name#23Febreeze-sys wants to merge 1 commit into
Febreeze-sys wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MixinPlugin.shouldApplyMixincheckstargetClassNamefor thecompat.package segment, but that segment only exists inmixinClassName. The condition is therefore never true, theCompatMods.loadedgate never runs, and compat mixins are applied unconditionally.Without Steam 'n' Rails installed,
compat.railways.flexiTrack.TrackTargetingBlockItemMixintargets a Create class and fails to attach onCREdgePointTypes.COUPLER. That takes Create down with it and crashes the game during mod loading:Fix
Changed the three
targetClassNamereferences inside thecompat.branch tomixinClassName. The rest of the logic already matches — the package segment (railways) is identical to the mod id inCompatMods.loaded.Testing
MC 1.21.1 / NeoForge 21.1.248 / Create 6.0.10, RailX 0.2.0-build.14, without Steam 'n' Rails installed. Game crashed on startup before the change, loads fine after.
EDIT: i tried to start the mod with Steam 'n' Rails installed and it crashed either btw.