attest : remove "storage" and "volume" from the field names#76
Draft
shjala wants to merge 1 commit intolf-edge:mainfrom
Draft
attest : remove "storage" and "volume" from the field names#76shjala wants to merge 1 commit intolf-edge:mainfrom
shjala wants to merge 1 commit intolf-edge:mainfrom
Conversation
shjala
force-pushed
the
generic_attest
branch
3 times, most recently
from
93859e5 to
10acaa1
Compare
Remove "storage" and "volume" from the field names, this is to make the field names more generic and not tied to storage or volume. This will make adding new keys to the attestation process easier. There has been no change in the wire format. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
shjala
force-pushed
the
generic_attest
branch
from
10acaa1 to
da1c41f
Compare
eriknordmark
approved these changes
Jan 2, 2025
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
LGTM but we need to coordinate these changes with the controllers so that they get the changes and no surprises that they need to do the renames in their source code.
Member
Author
OK, lets have this pending until I've informed the relevant developers. |
Contributor
|
The best time to do this change is when we bring in a new key to the attestation scheme. There will be changes required on both the sides at that time, and we can absorb this change as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove "storage" and "volume" from the field names, this is to make the field names more generic and not tied to storage or volume. This will make adding new keys to the attestation process easier. There has been no change in the wire format.