Skip to content

Fix mobile menu collapsing on scroll in iOS Safari #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterKnightDigital wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix mobile menu collapsing on scroll in iOS Safari #2261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions themes/le-2025/assets/js/le-2025-theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,13 @@ const Menu = {
mainNav.classList.remove('hidden');
mobileMenuToggle.setAttribute('aria-expanded', 'false');
} else if (isMobile && mainNav && mobileMenuToggle) {
// Only hide the nav when in true mobile mode (< 768px)
mainNav.classList.add('hidden');
// Only hide the nav when in true mobile mode (< 768px) and the menu
// is not intentionally open. On iOS Safari, scrolling fires a resize
// event (address bar hide/show changes innerHeight), which would
// otherwise collapse an open menu mid-scroll.
if (mobileMenuToggle.getAttribute('aria-expanded') !== 'true') {
mainNav.classList.add('hidden');
}
} else {
// For tablet sizes (768px-1023px), keep the nav visible
mainNav.classList.remove('hidden');
Expand Down
Loading