trees: Updates for mtpublisher HTTP client and writing checkpoints to tiles - #8970
Open
beautifulentropy wants to merge 1 commit into
Open
trees: Updates for mtpublisher HTTP client and writing checkpoints to tiles#8970beautifulentropy wants to merge 1 commit into
beautifulentropy wants to merge 1 commit into
Conversation
beautifulentropy
commented
Aug 21, 2026
beautifulentropy
commented
Member
- trees/checkpoint: Add signed note assembly for mirror submission and serving
- trees/cosignature: Add SignatureLine and accept signature lines as bytes
- trees/mirror: EntryPackage accepts entries as bytes
- trees/tiles: Add WriteCheckpoint
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-06
branch
from
August 21, 2026 22:05
4f43652 to
98e667d
Compare
beautifulentropy
force-pushed
the
paving-a-path-to-a-proper-publisher-06
branch
2 times, most recently
from
August 24, 2026 16:16
b230bf9 to
2fa617b
Compare
beautifulentropy
marked this pull request as ready for review
August 24, 2026 16:18
aarongable
approved these changes
Aug 24, 2026
| // WriteCheckpoint stores the log's signed checkpoint note at the "checkpoint" | ||
| // key under prefix per c2sp.org/tlog-tiles, overwriting the previous one. The | ||
| // note must be written only after the tiles its tree covers are published. | ||
| func WriteCheckpoint(ctx context.Context, s3c simpleS3, prefix string, signedNote []byte) error { |
Contributor
There was a problem hiding this comment.
Add a TODO here to make this an atomic compare-and-swap (using S3's If-Match etag header), since the CA knows what the previous checkpoint was. And since this is "just" a helper function, it could move into the MTCA itself, where taking the previous etag as an argument be more intuitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.