Skip to content

test(test-data): port lookup-interpolation, mixin-as-value & rootpath-escape-interpolation fixtures to alpha - #4527

Open
matthew-dean wants to merge 1 commit into
less:alphafrom
matthew-dean:port/master-fixtures
Open

test(test-data): port lookup-interpolation, mixin-as-value & rootpath-escape-interpolation fixtures to alpha#4527
matthew-dean wants to merge 1 commit into
less:alphafrom
matthew-dean:port/master-fixtures

Conversation

@matthew-dean

Copy link
Copy Markdown
Member

What this does

Three fixtures exist under packages/test-data on master but were missing from alpha. Since @less/test-data is a shared corpus consumed across branches (and by downstream compatibility suites), this ports them onto alpha so the corpus stays aligned:

Fixture Covers
tests-unit/lookup-interpolation [...] lookups inside @{…} interpolation — selectors, url(), at-rule name/prelude, property names, custom-property values, and the quoted/url silent-pass-through regressions
tests-error/eval/mixin-as-value using a mixin call as a value is an error
tests-config/rootpath-escape-interpolation rootpath combined with escaped-string interpolation

Alpha fixture gate

lookup-interpolation and mixin-as-value render / error as expected under the alpha fixture gate — the full pnpm --dir packages/less run test:alpha run stays green:

Less alpha fixtures passed: 89 rendered, 20 expected render failures, 81 friendly errors,
15 expected missing errors, 0 warnings, 2 expected missing warnings, 45 skipped.

rootpath-escape-interpolation exercises the rootpath option, which the alpha build does not support yet (validateAlphaOptions rejects it). It is added to the alpha-fixtures.mjs skip map next to the existing rootpath-rewrite-urls-* entries, with the same reason, so the fixture ships in the corpus without gating the alpha build. When rootpath support lands, removing that one skip line turns it into an active gate.

Notes

  • The sibling extend/extend-clearfix.less and media-nested-type / property-interpolation-lookup fixtures from the same master range are intentionally not included here: extend-clearfix.less is an @import helper with no expected CSS, and the other two do not yet pass the alpha engine — they are tracked separately.

…escape-interpolation fixtures from master

Bring three fixtures that exist on master into the alpha corpus so the
shared @less/test-data package stays aligned across branches:

- tests-unit/lookup-interpolation: [...] lookups inside @{...} interpolation
- tests-error/eval/mixin-as-value: using a mixin call as a value errors
- tests-config/rootpath-escape-interpolation: rootpath + escaped interpolation

lookup-interpolation and mixin-as-value render/error as expected under the
alpha fixture gate. rootpath-escape-interpolation exercises the rootpath
option, which the alpha build does not support yet (validateAlphaOptions
rejects it), so it is added to the alpha-fixtures skip map alongside the
existing rootpath-rewrite-urls entries.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6a489764-1eaf-4768-8fc9-485805b1e28d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns the alpha branch’s shared test corpus with master by adding regression fixtures for lookup interpolation, mixin calls used as values, and rootpath escaping.

  • Adds comprehensive lookup-interpolation input/output coverage.
  • Adds an expected evaluation error for using a mixin call as a property value.
  • Adds rootpath escaping coverage with fixture-specific options.
  • Skips the rootpath fixture in the alpha gate until rootpath rewriting is supported.

Confidence Score: 5/5

The PR appears safe to merge because the added fixtures match master and the unsupported rootpath case is correctly excluded from the alpha gate.

No actionable failures remain; every fixture has its corresponding expectation, the ports match master, and the new skip entry follows the alpha runner’s exact discovery and filtering contract.

Reviews (1): Last reviewed commit: "test(test-data): port lookup-interpolati..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant