Fix boolean() parsing for comparisons between inline condition expressions#4472
Draft
matthew-dean with Copilot wants to merge 2 commits into
Draft
Fix boolean() parsing for comparisons between inline condition expressions#4472matthew-dean with Copilot wants to merge 2 commits into
matthew-dean with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix confusing boolean logic in Less variables
Fix boolean() parsing for comparisons between inline condition expressions
Jul 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boolean((@foo = 1) = (@bar = a))was being misparsed, which surfaced as an undefined variable error even though the assignment existed. The parser handled precomputed boolean vars correctly but failed when equivalent condition expressions were inlined.Parser: allow condition-to-condition equality in custom condition contexts
packages/less/lib/less/parser/parser.jsso custom condition consumers (boolean(...),if(...)) can parse comparisons where operands are themselves condition expressions (including parenthesized forms).Regression coverage
packages/test-data/tests-unit/functions/functions.less:f: boolean((2 > 1) = (3 > 2));packages/test-data/tests-unit/functions/functions.css:f: true;Behavioral example