fix: preserve BF16 embedding weights for get_rows - #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve BF16 token embedding weights when they are consumed by
GET_ROWS.The generic
support_get_rows()check did not includeGGML_TYPE_BF16, so BF16 embedding weights could be converted to F32 even though the CPU backend already implements BF16GET_ROWS.This change:
GGML_TYPE_BF16to the genericGET_ROWScapability checktoken_embedding.weightas aGET_ROWSconsumer in the CLIP model loaderRelated Issue / Discussion
None.
Additional Information
Validated on an Intel Mac in CPU-only inference with MiniMax H3 / Qwen embedding weights.
The BF16 embedding tensor is preserved instead of being expanded to F32, and inference completes successfully.
Checklist