feat: enhanced third-party integrations#1632
Open
Cyberhan123 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds packaging/install support so consumers can discover and link the library via CMake find_package() and pkg-config.
Changes:
- Introduces pkg-config file template (
stable-diffusion.pc.in) for downstream builds. - Adds CMake package config template (
stable-diffusion-config.cmake.in) to expose an imported target and variables. - Extends
CMakeLists.txtwith install rules to generate/install the config + version files and the.pcfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| cmake/stable-diffusion.pc.in | Adds pkg-config metadata for stable-diffusion and its link flags |
| cmake/stable-diffusion-config.cmake.in | Adds CMake package config to expose include/lib dirs and an imported target |
| CMakeLists.txt | Adds generation + installation of CMake package files and pkg-config file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #1368. I've separated it and enhanced the CMake and pkg-config integration capabilities separately. However, if you want to release pkg-config, you may still need to test it.
Summary
This pull request adds installation support and package configuration for the project, making it easier for users to install and use the library via CMake and pkg-config. The changes introduce CMake configuration files, pkg-config support, and proper installation of headers and libraries.
Installation and packaging improvements:
CMakeLists.txtfor headers, libraries, and binaries, and configured installation directories using CMake variables. Also included generation and installation of CMake package config files and a pkg-config.pcfile.cmake/stable-diffusion-config.cmake.in, a CMake package configuration template, to allow downstream projects to easily find and use thestable-diffusionlibrary viafind_package. This includes versioning, dependency handling, and imported target setup.cmake/stable-diffusion.pc.into provide pkg-config support, enabling other build systems to discover the library and its dependencies.Checklist