Read and show Numeric answers in the exercise language - #6282
Open
rtibblesbot wants to merge 3 commits into
Open
rtibblesbot wants to merge 3 commits into
rtibblesbot wants to merge 3 commits into
Conversation
numerals.js vendors Kolibri's numeral normalization helpers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
marked this pull request as ready for review
October 3, 2026 03:57
Display uses the language's separators and digits; the XML keeps canonical xsd:double. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Falls back to the channel language, then the UI language. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6198-22d404
branch
from
October 3, 2026 04:34
e5dd3d7 to
9848e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xsd:double; shown in that language without groupingReferences
Fixes #6198. Headless mismatch: #6150. Vendored from: kolibri
numeralNormalization.jsReviewer guidance
QTI editor mounted with
languageset:fr, stored1234.5and30ar-EG, same itemfr, typing1,5(stores1.5)fr, invalid1,2,3axe: one color-contrast violation on "Add acceptable answer", same on
unstable.Open questions:
.falls back toxsd:double(French1.5stores1.5) unless the language groups with.; German1.5is rejected inline but stored raw, so headless validation passes it.Intl's minimum grouping digits, so Spanish1.234reads as1234.On a language change, unedited answers save as stored, even if the new language reads them differently (German
1,2).QA steps
Setup: in a channel, add an exercise with Language (under Audience on Details) set to Français (fr) and two Numeric questions: Q1 with
1,5,1234,5,-3,25; Q2 with12000,5,0,75.1.5,1234.5,-3.25and closed Q212000.5,0.75where French showed1,5…0,75, with no validation message. Open Q2, Add acceptable answer1,2, set Language to Deutsch (de) on Details and open Questions: Q2 shows1,2as typed with "Must be a valid number (e.g. 12; 0,5; -3,14)", the other answers in comma form.Evidence
Change the exercise language with stored Numeric answers
1,5,1234,5,-3,251.5,1234.5,-3.25; Q212000.5,0.75; no errors1,5,1234,5,-3,25;12000,5,0,751,2typed in Q2, flagged with English examples, Q2 Incomplete1,2kept as typed, flagged with German exampless5-language-switch-flow.webm
More captures (3)
1,5,1234,5,-3,250,75changed to1.234,812000.5,1234.8AI usage
Claude Code planned and implemented the change from the issue's rules. Verified with the QTIEditor and channelEdit Jest suites, pre-commit, and screenshots of the editor in a headless browser.
🤖 Generated with Claude Code
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-10-03 04:34 UTC