-
Notifications
You must be signed in to change notification settings - Fork 34
Add JSON Schema for learning objectives #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON Schema for learning objectives #196
Conversation
d03c595 to
d4679b1
Compare
d4679b1 to
cffae05
Compare
LianaHarris360
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @AlexVelezLl. Overall, the changes make sense to me and I appreciate the good test coverage. My only suggestions are for stricter regex for some of the field/string validations.
|
Thanks @LianaHarris360! I have made the JSON schema spec more restrictive! Just one little question: What will be the identifier for the assessment questions that will be stored in this object? I have implemented the regex following the question item validator in Kolibri, since it seems the question_id is only unique within a quiz. |
|
I doubled checked with Richard and he confirmed that the identifier for the assessment questions will either reference the assessment ids that are on the Studio |
6a7ef1e to
409a26b
Compare
|
Thanks @LianaHarris360! Just updated the PR! 👐 |
409a26b to
4c9e2cb
Compare
4c9e2cb to
55e4a80
Compare
Summary
Adds JSON Schema for unit learning objectives and unit tests.
References
Closes #189.
Reviewer guidance