Skip to content

Conversation

@AlexVelezLl
Copy link
Member

Summary

Adds JSON Schema for unit learning objectives and unit tests.

References

Closes #189.

Reviewer guidance

  • Are tests running?
  • Are tests testing the right things?
  • Is the new schema following the issue requirements?

@AlexVelezLl AlexVelezLl force-pushed the add_unit_learning_objectives_schema branch from d03c595 to d4679b1 Compare December 4, 2025 20:23
@AlexVelezLl AlexVelezLl force-pushed the add_unit_learning_objectives_schema branch from d4679b1 to cffae05 Compare December 4, 2025 20:33
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @AlexVelezLl. Overall, the changes make sense to me and I appreciate the good test coverage. My only suggestions are for stricter regex for some of the field/string validations.

@AlexVelezLl
Copy link
Member Author

Thanks @LianaHarris360! I have made the JSON schema spec more restrictive! Just one little question: What will be the identifier for the assessment questions that will be stored in this object? I have implemented the regex following the question item validator in Kolibri, since it seems the question_id is only unique within a quiz.

@LianaHarris360
Copy link
Member

I doubled checked with Richard and he confirmed that the identifier for the assessment questions will either reference the assessment ids that are on the Studio AssessmentItem model) and be UUID4 or forced to be UUID5 in Ricecooker.

@AlexVelezLl AlexVelezLl force-pushed the add_unit_learning_objectives_schema branch from 6a7ef1e to 409a26b Compare December 10, 2025 22:49
@AlexVelezLl
Copy link
Member Author

Thanks @LianaHarris360! Just updated the PR! 👐

@AlexVelezLl AlexVelezLl force-pushed the add_unit_learning_objectives_schema branch from 409a26b to 4c9e2cb Compare December 12, 2025 21:05
@AlexVelezLl AlexVelezLl force-pushed the add_unit_learning_objectives_schema branch from 4c9e2cb to 55e4a80 Compare December 12, 2025 21:16
@LianaHarris360 LianaHarris360 merged commit 50476b8 into learningequality:main Dec 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document JSONSchema for Learning Objectives

2 participants